Re: [LTP] [PATCH 4/4] configure: Add missing files for removal in ac-maintainer-clean target

Petr Vorel
2025-04-01T07:59:17Z

> From: Ricardo B. Marlière <rbm@suse.com>

> The ac-maintainer-clean target should be responsible to remove all
> generated files, in this case from `make autotools`. Add the remaining to
> the list and also make sure it happens before any call to other targets in
> nested Makefiles, so if there are any errors in them, they happen lastly.

> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
> ---
> include/mk/automake.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/include/mk/automake.mk b/include/mk/automake.mk
> index d96da8313dc8dc4f4d6d728db72b0f749d269bfe..40fab124370d7c9a71fa502ff75e39cb1d31197f 100644
> --- a/include/mk/automake.mk
> +++ b/include/mk/automake.mk
> @@ -63,11 +63,11 @@ ac-clean::

> ac-distclean:: ac-clean
> ac-maintainer-clean:: ac-distclean
> + $(RM) -f $(AUTOMAKE_FILES) aclocal.m4 compile config.guess config.sub configure m4/Makefile.in

OK, this removes "compile" file (Wrapper for compilers which do not understand
'-c -o'). Interesting. IMHO the rest of newly explicitly added files (e.g.
config.guess, config.sub, m4/Makefile.in) were removed without this change (part
of $(AUTOMAKE_FILES) ).

rm -f -f aclocal.m4 configure config.guess config.sub install-sh missing m4/Makefile.in
rm -f -f include/*config.h.in

Kind regards,
Petr

> + $(MAKE) -C "$(top_srcdir)/include" $@;
> for d in $(AUTOCONFED_SUBDIRS); do \
> $(MAKE) -C "$(top_srcdir)/$$d" $@; \
> done
> - $(RM) -f aclocal.m4 configure $(AUTOMAKE_FILES) m4/Makefile.in
> - $(RM) -f include/*config.h.in

> # Don't include config.h, or make will (rightfully) whine about overriding
> # rules.
> @@ -82,10 +82,10 @@ AUTOGENERATED_FILES = \
> m4/Makefile

> distclean:: %: clean ac-distclean
> + $(RM) -f $(AUTOGENERATED_FILES)
> for d in $(AUTOCONFED_SUBDIRS); do \
> $(MAKE) -C "$(top_srcdir)/$$d" $@; \
> done
> - $(RM) -f $(AUTOGENERATED_FILES)

> maintainer-clean:: distclean ac-maintainer-clean