Re: [LTP] [PATCH v4 0/5] Update doc related Makefile

Andrea Cervesato via ltp
2025-03-28T13:18:52Z

Hi Petr,

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

On 3/28/25 10:57, Petr Vorel wrote:
> Changes from v3 (all by Andrea):
>
> * Add setup (alias to .venv)
> * Move sphinx to requirements.txt (therefore remove handling in Makefile)
> * Add support also for fish (csh/tcsh ignored, supporting: fish, bash/zsh)
> * Use 'setup' instead of '.venv' in the top level doc target
>
> NOTE: 'distclean' of doc/ directory is not in the top level directory
> (IMHO not needed).
>
> Are we there yet?
>
> Kind regards,
> Petr
>
> Link to v3:
> https://patchwork.ozlabs.org/project/ltp/list/?series=449828&state=*
> https://lore.kernel.org/ltp/20250324234016.367228-1-pvorel@suse.cz/T/#t
>
> Link to v2:
> https://patchwork.ozlabs.org/project/ltp/list/?series=443894&state=*
> https://lore.kernel.org/ltp/20250211233552.1990618-1-pvorel@suse.cz/#r
>
> Link to v1:
> https://patchwork.ozlabs.org/project/ltp/patch/20250206143421.1571918-4-pvorel@suse.cz/
> https://lore.kernel.org/ltp/20250206143421.1571918-4-pvorel@suse.cz/
>
> Petr Vorel (5):
> doc/Makefile: Remove also metadata/ltp.json
> doc: Add sphinx to requirements.txt
> doc/Makefile: Allow to create and use .venv
> Makefile: Update 'doc' target, add 'doc-clean'
> doc: Note 'make doc' in the building doc
>
> Makefile | 8 +++++++-
> doc/Makefile | 25 ++++++++++++++++++++++---
> doc/developers/documentation.rst | 4 ++--
> doc/requirements.txt | 1 +
> 4 files changed, 32 insertions(+), 6 deletions(-)
>