From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 2/4] ci: add patchwork communication script
Date: Tue, 15 Apr 2025 11:04:08 +0200 [thread overview]
Message-ID: <20250415090408.GA473949@pevik> (raw)
In-Reply-To: <c7525a80-2415-4773-ac9b-f82e1e7978f2@suse.com>
Hi Andrea,
> Hi Petr,
> On 4/14/25 16:02, Petr Vorel wrote:
> > Generally LGTM, few notes below.
> > Feel free to ignore them, note at '-e' and '-z "$run" -o' (at the end) are bugs
> > worth to be fixed.
> We can remove -e, but what about -x ? It's verbose, but it's quite helping
> in the CI.
> Maybe I can just set -x before running the script in the workflow.
Sure, I'd definitely keep -x.
-e is up to you. You can keep it, but have to wrap commands with if:
if ! curl ...; then
echo ... >&2
exit 1
fi
Kind regards,
Petr
> The rest looks ok.
> - Andrea
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-15 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 11:43 [LTP] [PATCH v5 0/4] Support for Patchwork CI Andrea Cervesato
2025-04-11 11:43 ` [LTP] [PATCH v5 1/4] ci: install dependences for patchwork-ci script Andrea Cervesato
2025-04-14 12:51 ` Petr Vorel
2025-04-14 13:00 ` Andrea Cervesato via ltp
2025-04-11 11:43 ` [LTP] [PATCH v5 2/4] ci: add patchwork communication script Andrea Cervesato
2025-04-14 14:02 ` Petr Vorel
2025-04-15 8:50 ` Andrea Cervesato via ltp
2025-04-15 9:04 ` Petr Vorel [this message]
2025-04-11 11:43 ` [LTP] [PATCH v5 4/4] ci: apply patchwork series in ci-docker-build workflow Andrea Cervesato
2025-04-11 12:07 ` [LTP] [PATCH v5 0/4] Support for Patchwork CI Petr Vorel
2025-04-11 12:10 ` Cyril Hrubis
2025-04-11 12:59 ` Petr Vorel
2025-04-11 13:06 ` Andrea Cervesato via ltp
2025-04-14 15:41 ` Petr Vorel
2025-04-15 7:53 ` Andrea Cervesato via ltp
2025-04-15 9:49 ` Petr Vorel
2025-04-15 9:54 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415090408.GA473949@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox