Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] tst_cgroup: Add "dmem" cgroup controller
Date: Thu, 17 Apr 2025 08:55:24 +0200	[thread overview]
Message-ID: <20250417065524.GB638986@pevik> (raw)
In-Reply-To: <CAEemH2ciYNmtKLz-ZM+wACTQwAvUA=EcOoJNdQprtRxCMA0azA@mail.gmail.com>

Hi Li, Avinesh,

> Hi Petr, Avinesh,

> On Wed, Apr 16, 2025 at 6:08 AM Petr Vorel <pvorel@suse.cz> wrote:

...
> > +static const struct cgroup_file dmem_ctrl_files[] = {
> > +       { "dmem.capacity", NULL, CTRL_DMEM },
> > +       { "dmem.current", NULL, CTRL_DMEM },


> It is no harm to add more ctrl_files like dmem.max, dmem.min, dmem.low,
> which might be useful in the future.

Good idea, I added them before merge.

> Anyway, looks good to me.

Thank you both for your review.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2025-04-17  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 22:08 [LTP] [PATCH 1/2] tst_cgroup: Add "dmem" cgroup controller Petr Vorel
2025-04-15 22:08 ` [LTP] [PATCH 2/2] cgroup_regression_test.sh: simplify last controller detection Petr Vorel
2025-04-16  4:44   ` Li Wang via ltp
2025-04-16  7:35   ` Avinesh Kumar
2025-04-16  4:44 ` [LTP] [PATCH 1/2] tst_cgroup: Add "dmem" cgroup controller Li Wang via ltp
2025-04-17  6:55   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417065524.GB638986@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox