From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 232ECC369D9 for ; Wed, 30 Apr 2025 11:47:27 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A7BA43CBC98 for ; Wed, 30 Apr 2025 13:47:25 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 90F6A3CB38A for ; Wed, 30 Apr 2025 13:47:09 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id A27791A0092C for ; Wed, 30 Apr 2025 13:47:08 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 263811F449; Wed, 30 Apr 2025 11:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746013627; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpCEhS4eaA2sDt+pmcdv48zEiRiibFkSrNwhndusnPY=; b=hKJUYno7JTaknZavkHB646/2eM91BIk9FAwh4ShOo7DY8b2pkxV7z/ABNFsjlzqrF65Jo+ 5q+Cgdc3fZSS9r1ymsHJNxC/mvImdLBj+qbNUXUkpCWVM3i8mhdHqlT2piLVQmGrJjugrG qt0pOD3urczjehKstlZq7PupJWgPC7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746013627; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpCEhS4eaA2sDt+pmcdv48zEiRiibFkSrNwhndusnPY=; b=n2Y7WrSmhSQH+AHHRR8wT8j3KYPe7s/Ab4fvsVkCUpJl6fQkPQt4BYeMqapUo7U8PiLhZk pS1UCahT5hpb3SCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746013627; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpCEhS4eaA2sDt+pmcdv48zEiRiibFkSrNwhndusnPY=; b=hKJUYno7JTaknZavkHB646/2eM91BIk9FAwh4ShOo7DY8b2pkxV7z/ABNFsjlzqrF65Jo+ 5q+Cgdc3fZSS9r1ymsHJNxC/mvImdLBj+qbNUXUkpCWVM3i8mhdHqlT2piLVQmGrJjugrG qt0pOD3urczjehKstlZq7PupJWgPC7U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746013627; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpCEhS4eaA2sDt+pmcdv48zEiRiibFkSrNwhndusnPY=; b=n2Y7WrSmhSQH+AHHRR8wT8j3KYPe7s/Ab4fvsVkCUpJl6fQkPQt4BYeMqapUo7U8PiLhZk pS1UCahT5hpb3SCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DBB4F139E7; Wed, 30 Apr 2025 11:47:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lOSeNLoNEmjzUQAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 11:47:06 +0000 Date: Wed, 30 Apr 2025 13:47:01 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: <20250430114701.GA16680@pevik> References: <20250228172439.3276777-1-pvorel@suse.cz> <20250228172439.3276777-5-pvorel@suse.cz> <20250425183345.GA79209@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-7.50 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.7 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCH 4/5] shell lib: Add basic support for test cleanup X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Cyril, > Hi! > And one possible solution is to source the environment first and the > loader last, on the top of your shell-loader-setup-cleanup.v2 branch: > diff --git a/testcases/lib/tests/shell_loader.sh b/testcases/lib/tests/shell_loader.sh > index eeed122c1..01acf6d35 100755 > --- a/testcases/lib/tests/shell_loader.sh > +++ b/testcases/lib/tests/shell_loader.sh > @@ -14,6 +14,8 @@ > # } > # --- > +. tst_env.sh > + OK, that is the missing piece, thank you! i.e. sourcing tst_env.sh at the beginning before test function setup and tst_loader.sh at the end after test function setup). I thought we would avoid sourcing two files in the tests, that's why I haven't tried, but that's a minor detail. And it's better solution than having tst_exec.sh, which requires tst_run_shell.c modification, just to do the same thing (source tst_env.sh). Kind regards, Petr > tst_test() > { > tst_res TPASS "Shell loader works fine!" > diff --git a/testcases/lib/tst_env.sh b/testcases/lib/tst_env.sh > index 68f9a0daa..585790a7d 100644 > --- a/testcases/lib/tst_env.sh > +++ b/testcases/lib/tst_env.sh > @@ -18,11 +18,6 @@ if [ -z "$LINENO" ]; then > LINENO=-1 > fi > -if [ -z "$LTP_IPC_PATH" ]; then > - echo "This script has to be executed from a LTP loader!" > - exit 1 > -fi > - > tst_brk_() > { > tst_res_ "$@" -- Mailing list info: https://lists.linux.it/listinfo/ltp