Re: [LTP] [PATCH v1] fsconfig04.c: Check FSCONFIG_SET_PATH

Wei Gao via ltp
2025-05-26T02:30:31Z

On Thu, May 22, 2025 at 10:56:37PM +0200, Petr Vorel wrote:
> Hi Wei,
>
> I'm sorry not a real review, just point out obvious API errors.
Thanks for pointing that out :)

>
> > +#include "lapi/fsmount.h"
>
> > +#include "old/old_device.h"
> Why this?
tst_acquire_loop_device is needed in this case, and i saw following test
case using old_device.h, so i just copy it into current case.
testcases/lib/tst_device.c
>
> > +
> > +
> > + .all_filesystems = 1,
> > + .skip_filesystems = (const char *const []){"ntfs", "vfat", "exfat",
> > + "ext2", "tmpfs", "xfs", "btrfs", NULL},
> So you skip nearly everything, right?
Yes, ONLY ext3 and ext4 support journal setup

> Why not use .mount_device = 1 ? That would mount the default filesystem.
This case need format default device with ext3 opts='-F -J device=/dev/loop1' firstly,
so the device can not be mounted before format.
>
> Kind regards,
> Petr
>
> > +};