Re: [LTP] [PATCH v3] fsconfig04.c: Check FSCONFIG_SET_PATH

Petr Vorel
2026-03-16T08:49:46Z

Hi Andrea, Wei,

> On Fri, Dec 12, 2025 at 10:29:35AM +0100, Andrea Cervesato wrote:
> > Hi!

> > please, re-read the previous reviews before submitting a new version,
> > because there are still some issues not achieved.

If you *were* a concrete what is wrong, you'd have saved Wei's and my time :).

> Thanks for take a look.
> I think Cyril comments should be fixed in current version after recheck, so i move patch into
> Needs Review in patchwork again.

I'd also say all issues has been fixed. What exactly do you mean?

Also, test needs rebase after Wei's and Li's changes to fix compilation.

Kind regards,
Petr

+++ testcases/kernel/syscalls/fsconfig/fsconfig04.c
@@ -24,7 +24,7 @@

#include "tst_test.h"
#include "lapi/fsmount.h"
-#include "old/old_device.h"
+#include "old/tso_device.h"

#define MNTPOINT "mntpoint"
#define LOOP_DEV_SIZE 10
@@ -150,9 +150,9 @@ static struct tst_test test = {
.needs_root = 1,
.format_device = 1,
.mntpoint = MNTPOINT,
- .needs_cmds = (const char *[]) {
- "tune2fs",
- NULL
+ .needs_cmds = (struct tst_cmd[]) {
+ {.cmd = "tune2fs"},
+ {}
},
.filesystems = (struct tst_fs []) {
{.type = "ext3"},