Re: [LTP] [PATCH v3] fsconfig04.c: Check FSCONFIG_SET_PATH

Petr Vorel
2026-03-24T12:50:40Z

Hi Wei,

> + tune2fs = popen(path, "r");
Could you please use SAFE_POPEN() ?

Maybe if you don't get any feedback could you please send v4
- rebased v3 with the changes below?

Kind regards,
Petr

> +++ testcases/kernel/syscalls/fsconfig/fsconfig04.c
> @@ -24,7 +24,7 @@

> #include "tst_test.h"
> #include "lapi/fsmount.h"
> -#include "old/old_device.h"
> +#include "old/tso_device.h"

> #define MNTPOINT "mntpoint"
> #define LOOP_DEV_SIZE 10
> @@ -150,9 +150,9 @@ static struct tst_test test = {
> .needs_root = 1,
> .format_device = 1,
> .mntpoint = MNTPOINT,
> - .needs_cmds = (const char *[]) {
> - "tune2fs",
> - NULL
> + .needs_cmds = (struct tst_cmd[]) {
> + {.cmd = "tune2fs"},
> + {}
> },
> .filesystems = (struct tst_fs []) {
> {.type = "ext3"},