Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: "Ricardo B. Marlière" <rbm@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v4 3/8] syscalls/mknod03: Convert to new API
Date: Thu, 5 Jun 2025 09:32:31 +0200	[thread overview]
Message-ID: <20250605073231.GC1190804@pevik> (raw)
In-Reply-To: <20250425-conversions-mknod-v4-3-222e0d2e7ef1@suse.com>

Hi Ricardo, Andrea,

...
> +/*\
> + * Verify that mknod(2) succeeds when used to create a filesystem node with
> + * set-group-ID bit set on a directory with set-group-ID bit set. The node
> + * created should have set-group-ID bit set and its gid should be equal to
> + * the "nobody" gid.
>   */

> -#define MODE_RWX	S_IFIFO | S_IRWXU | S_IRWXG | S_IRWXO
> -#define MODE_SGID       S_IFIFO | S_ISGID | S_IRWXU | S_IRWXG | S_IRWXO
...
> +#define MODE_RWX 0777
> +#define MODE_SGID (S_ISGID | 0777)

And here also dropped S_IFIFO. Did I overlook a discussion that mknod() can be
called without S_IFIFO? (I don't think so).

And old tests use S_IFIFO also for mkdir(), but that is IMHO not needed.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-06-05  7:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 18:06 [LTP] [PATCH v4 0/8] syscalls/mknod: Refactor all tests Ricardo B. Marlière via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 1/8] syscalls/mknod01: Fix checkpatch.pl warnings Ricardo B. Marlière via ltp
2025-06-03 11:08   ` Andrea Cervesato via ltp
2025-06-05  7:26   ` Petr Vorel
2025-04-25 18:06 ` [LTP] [PATCH v4 2/8] syscalls/mknod02: Use relative path to avoid use of SAFE_CHDIR Ricardo B. Marlière via ltp
2025-05-20 12:46   ` Andrea Cervesato via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 3/8] syscalls/mknod03: Convert to new API Ricardo B. Marlière via ltp
2025-06-05  7:32   ` Petr Vorel [this message]
2025-04-25 18:06 ` [LTP] [PATCH v4 4/8] syscalls/mknod04: " Ricardo B. Marlière via ltp
2025-06-03 13:44   ` Andrea Cervesato via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 5/8] syscalls/mknod05: " Ricardo B. Marlière via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 6/8] syscalls/mknod06: " Ricardo B. Marlière via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 7/8] syscalls/mknod07: " Ricardo B. Marlière via ltp
2025-04-25 18:06 ` [LTP] [PATCH v4 8/8] syscalls/mknod08: " Ricardo B. Marlière via ltp
2025-06-05  7:23   ` Petr Vorel
2025-06-05 12:53     ` Ricardo B. Marlière via ltp
2025-06-04 14:36 ` [LTP] [PATCH v4 0/8] syscalls/mknod: Refactor all tests Andrea Cervesato via ltp
2025-06-04 14:37   ` Ricardo B. Marlière via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605073231.GC1190804@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rbm@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox