Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: "Ricardo B. Marlière" <rbm@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v5 3/8] syscalls/mknod03: Convert to new API
Date: Fri, 6 Jun 2025 14:33:15 +0200	[thread overview]
Message-ID: <20250606123315.GA1306605@pevik> (raw)
In-Reply-To: <DAFFK4OBLBWY.3VACS2RP961A8@suse.com>

Hi Ricardo,

> On Fri Jun 6, 2025 at 8:49 AM -03, Petr Vorel wrote:
> > Hi Ricardo,

> >>  testcases/kernel/syscalls/mknod/mknod03.c | 313 ++++--------------------------
> >>  1 file changed, 39 insertions(+), 274 deletions(-)

> >> diff --git a/testcases/kernel/syscalls/mknod/mknod03.c b/testcases/kernel/syscalls/mknod/mknod03.c
> >> index 7ecadb5b37c3ab7eded90aa8a6d1e27f07236b1f..00a6133f7a15c1dd9c9e67ba08315f218f16d0d6 100644
> >> --- a/testcases/kernel/syscalls/mknod/mknod03.c
> >> +++ b/testcases/kernel/syscalls/mknod/mknod03.c
> >> @@ -1,296 +1,61 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> > nit: This should be v2+

> > // SPDX-License-Identifier: GPL-2.0-or-later

> Weird, I have that as a snippet but must have copied from another file
> on that occasion.

Although the default license for new files is GPL-2.0-or-later,
unfortunately it can be taken as a default when rewriting the file.
We had a lovely lawsuits with some companies, that's why it's also good to pay
attention to the license.

Anyway, thank you for your work, merged with this change.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-06-06 12:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 12:52 [LTP] [PATCH v5 0/8] syscalls/mknod: Refactor all tests Ricardo B. Marlière via ltp
2025-06-05 12:52 ` [LTP] [PATCH v5 1/8] syscalls/mknod01: Fix checkpatch.pl warnings Ricardo B. Marlière via ltp
2025-06-05 12:52 ` [LTP] [PATCH v5 2/8] syscalls/mknod02: Use relative path to avoid use of SAFE_CHDIR Ricardo B. Marlière via ltp
2025-06-06 10:08   ` Petr Vorel
2025-06-05 12:52 ` [LTP] [PATCH v5 3/8] syscalls/mknod03: Convert to new API Ricardo B. Marlière via ltp
2025-06-06 10:34   ` Petr Vorel
2025-06-06 11:49   ` Petr Vorel
2025-06-06 11:57     ` Ricardo B. Marlière via ltp
2025-06-06 12:33       ` Petr Vorel [this message]
2025-06-05 12:52 ` [LTP] [PATCH v5 4/8] syscalls/mknod04: " Ricardo B. Marlière via ltp
2025-06-06 10:48   ` Petr Vorel
2025-06-06 11:05   ` Ricardo B. Marlière via ltp
2025-06-06 11:27   ` Petr Vorel
2025-06-06 11:31     ` Ricardo B. Marlière via ltp
2025-06-06 13:59       ` Petr Vorel
2025-06-05 12:52 ` [LTP] [PATCH v5 5/8] syscalls/mknod05: " Ricardo B. Marlière via ltp
2025-06-06 11:44   ` Petr Vorel
2025-06-06 11:45     ` Ricardo B. Marlière via ltp
2025-06-05 12:52 ` [LTP] [PATCH v5 6/8] syscalls/mknod06: " Ricardo B. Marlière via ltp
2025-06-06 12:06   ` Petr Vorel
2025-06-05 12:52 ` [LTP] [PATCH v5 7/8] syscalls/mknod07: " Ricardo B. Marlière via ltp
2025-06-06 12:21   ` Petr Vorel
2025-06-05 12:52 ` [LTP] [PATCH v5 8/8] syscalls/mknod08: " Ricardo B. Marlière via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250606123315.GA1306605@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rbm@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox