From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFCB8C83F1A for ; Tue, 22 Jul 2025 13:09:22 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3AADF3CCCCD for ; Tue, 22 Jul 2025 15:09:21 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D9B873C20D2 for ; Tue, 22 Jul 2025 15:09:04 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 0A9FE1400F2B for ; Tue, 22 Jul 2025 15:09:03 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F5511F788; Tue, 22 Jul 2025 13:09:03 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 39DBF132EA; Tue, 22 Jul 2025 13:09:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id I8G5DG+Nf2gtAgAAD6G6ig (envelope-from ); Tue, 22 Jul 2025 13:09:03 +0000 Date: Tue, 22 Jul 2025 15:09:01 +0200 From: Petr Vorel To: Tiezhu Yang Message-ID: <20250722130901.GA75167@pevik> References: <20250722115230.2521-1-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250722115230.2521-1-yangtiezhu@loongson.cn> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 4F5511F788 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Virus-Scanned: clamav-milter 1.0.7 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] ltp_block_dev: Check HAVE_LINUX_GENHD_H to include genhd.h X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Linux Test Project Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Tiezhu, > After the LTP commit d4dd360b05f8 ("device-drivers/acpi/ltp_acpi_cmds: > Fix build errors"), HAVE_LINUX_GENHD_H is defined to 1 if you have the > header file. > The macro definition DISK_NAME_LEN may be completely removed, so it is > better to use #ifdef HAVE_LINUX_GENHD_H to include genhd.h. Suggested-by: Petr Vorel # :) https://lore.kernel.org/ltp/20250718063028.GA1387837@pevik/ > Signed-off-by: Tiezhu Yang > --- > By the way, it seems that the following file is not used, should it be > deleted? If yes, I will send a formal patch later. Indeed, at least 4.12 based kernel does not need it. In that case please send a new patch. Thanks! Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp