From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] cve: add CVE-2025-38236 test
Date: Tue, 12 Aug 2025 14:22:15 +0200 [thread overview]
Message-ID: <20250812122215.GE843668@pevik> (raw)
In-Reply-To: <20250812-cve_2025_38236-v2-1-76abeeaeaee6@suse.com>
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
> Changes in v2:
> - use MSG_DONTWAIT
> - add reference in the description
> - reduce if/else nesting
> - use different data for send()
> - Link to v1: https://lore.kernel.org/r/20250812-cve_2025_38236-v1-1-e3617ada69c6@suse.com
+1
...
> + ret = recv(sock[0], &dummy, 1, MSG_DONTWAIT);
> + if (ret == -1) {
> + if (errno == EWOULDBLOCK) {
> + tst_res(TPASS, "Can't read out-of-band data from normal stream");
> + return;
> + }
> +
> + tst_brk(TBROK | TERRNO, "recv error");
> + return;
nit: this return is not needed (can be removed before merge).
We have compilers smart enough to know that tst_brk() quits,
although there might be a warning on oldest supported toolchains.
Kind regards,
Petr
> + }
...
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-08-12 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 12:01 [LTP] [PATCH v2] cve: add CVE-2025-38236 test Andrea Cervesato
2025-08-12 12:22 ` Petr Vorel [this message]
2025-08-12 12:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812122215.GE843668@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox