From: Li Wang via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] mount05: check if mount path exist before tst_is_mounted
Date: Fri, 22 Aug 2025 15:22:04 +0800 [thread overview]
Message-ID: <20250822072204.2191382-2-liwang@redhat.com> (raw)
In-Reply-To: <20250822072204.2191382-1-liwang@redhat.com>
tst_is_mounted() now internally resolves the mount path via realpath(),
which will fail if the path does not exist. In mount05, MNTPOINT2 may
not always be created during the test flow, so calling tst_is_mounted()
directly could produce misleading warnings or errors.
Add an explicit access(MNTPOINT2, F_OK) check before calling
tst_is_mounted(), ensuring we only query mounts for existing paths.
Signed-off-by: Li Wang <liwang@redhat.com>
---
testcases/kernel/syscalls/mount/mount05.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/mount/mount05.c b/testcases/kernel/syscalls/mount/mount05.c
index 66e102a32..5585e230e 100644
--- a/testcases/kernel/syscalls/mount/mount05.c
+++ b/testcases/kernel/syscalls/mount/mount05.c
@@ -35,7 +35,7 @@ static void cleanup(void)
if (tst_is_mounted(MNTPOINT1))
SAFE_UMOUNT(MNTPOINT1);
- if (tst_is_mounted(MNTPOINT2))
+ if (!access(MNTPOINT2, F_OK) && tst_is_mounted(MNTPOINT2))
SAFE_UMOUNT(MNTPOINT2);
}
--
2.49.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-08-22 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 7:22 [LTP] [PATCH 1/2] tst_device: refine tst_is_mounted() Li Wang via ltp
2025-08-22 7:22 ` Li Wang via ltp [this message]
2025-08-22 7:28 ` [LTP] [PATCH 2/2] mount05: check if mount path exist before tst_is_mounted Li Wang via ltp
2025-08-22 7:48 ` [LTP] [PATCH v2 2/2] mount: check path exists before tst_is_mounted in cleanup Li Wang via ltp
2025-08-22 8:02 ` Wei Gao via ltp
2025-08-22 8:12 ` Li Wang via ltp
2025-08-22 8:32 ` Wei Gao via ltp
2025-08-22 7:45 ` [LTP] [PATCH 1/2] tst_device: refine tst_is_mounted() Wei Gao via ltp
2025-08-26 1:16 ` Li Wang via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822072204.2191382-2-liwang@redhat.com \
--to=ltp@lists.linux.it \
--cc=liwang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox