From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sched_football: synchronize with kickoff flag to reduce skew
Date: Thu, 4 Sep 2025 11:48:42 +0200 [thread overview]
Message-ID: <20250904094842.GA52619@pevik> (raw)
In-Reply-To: <20250904064126.125661-1-liwang@redhat.com>
Hi Li,
...
> static void do_setup(void)
> {
> + if (!tst_check_preempt_rt())
> + tst_brk(TCONF, "Test requires real-time kernel");
I guess this itself fix many false positives :). I'm ok with requesting RT
kernel, but just to remind the claim originated from Cyril [1] "sched_football
is useful not only for testing realtime". So was Cyril wrong?
(I'm ok to keep the test in runtest/sched even requesting RT kernel, because
runtest/sched and other LTP tests are run on both RT and non-RT.
The rest LGTM, thanks for stabilising the test.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/commit/3a8e38fc2c46c886525bbb708dff462c6b633d32
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-04 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:41 [LTP] [PATCH] sched_football: synchronize with kickoff flag to reduce skew Li Wang via ltp
2025-09-04 7:20 ` Andrea Cervesato via ltp
2025-09-04 9:48 ` Petr Vorel [this message]
2025-09-04 9:54 ` Cyril Hrubis
2025-09-04 10:04 ` Li Wang via ltp
2025-09-04 10:08 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904094842.GA52619@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox