From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/cachestat01: Fix num_shift calculation
Date: Thu, 11 Sep 2025 11:34:48 +0200 [thread overview]
Message-ID: <20250911093448.GA20035@pevik> (raw)
In-Reply-To: <20250911085700.27540-1-chrubis@suse.cz>
Hi Cyril,
> The calculation added in commit 8422d46 works only for 64k page size.
> This commit fixes the calculation so that it properly detects maximal
> num_shift regardless the page_size.
Thanks for fixing this!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Closes #1258
very nit: I tend to use a regular link, i.e.:
Closes: https://github.com/linux-test-project/ltp/pull/1258
Why? in case project project will be moved elsewhere (gitlab?) and one will need
to figure out the link (whether it's an issue or PR).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-11 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 8:57 [LTP] [PATCH] syscalls/cachestat01: Fix num_shift calculation Cyril Hrubis
2025-09-11 9:34 ` Petr Vorel [this message]
2025-09-12 8:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911093448.GA20035@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox