public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: ltp@lists.linux.it
Cc: Mark Wielaard <mark@klomp.org>, Martin Cermak <mcermak@redhat.com>
Subject: [LTP] [PATCH] mmap04: Make sure the scanf address format is at least 8 hex chars
Date: Thu, 18 Sep 2025 17:26:40 +0200	[thread overview]
Message-ID: <20250918152640.1146279-1-mark@klomp.org> (raw)

The addresses in /proc/self/maps are at least 8 hex chars. Zeros are
added to the front of the address when shorted (both on 32bit and
64bit systems.

Under valgrind the mmaps used in kernel/syscalls/mmap/mmap04.c come
out very low in the address space and might be shorter than 8 hex
chars. This causes the scanf to fail:
mmap04.c:62: TBROK: Expected 1 conversions got 0 FILE '/proc/self/maps'

Fix this by using "%08" PRIxPTR when creating the fmt used.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 testcases/kernel/syscalls/mmap/mmap04.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/mmap/mmap04.c b/testcases/kernel/syscalls/mmap/mmap04.c
index 4a050b7b50da..5b28180df29b 100644
--- a/testcases/kernel/syscalls/mmap/mmap04.c
+++ b/testcases/kernel/syscalls/mmap/mmap04.c
@@ -58,7 +58,8 @@ static void run(unsigned int i)
 
 	addr2 = SAFE_MMAP(addr1 + pagesize, pagesize, tc->prot, tc->flags | MAP_FIXED, -1, 0);
 
-	sprintf(fmt, "%" PRIxPTR "-%%*x %%s", (uintptr_t)addr2);
+	/* A /proc/self/maps address is at least 8 hex (left zero padded) */
+	sprintf(fmt, "%08" PRIxPTR "-%%*x %%s", (uintptr_t)addr2);
 	SAFE_FILE_LINES_SCANF("/proc/self/maps", fmt, perms);
 
 	if (!strcmp(perms, tc->exp_perms)) {
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

             reply	other threads:[~2025-09-18 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 15:26 Mark Wielaard [this message]
2025-09-18 15:30 ` [LTP] [PATCH] mmap04: Make sure the scanf address format is at least 8 hex chars Mark Wielaard
2025-09-22  7:48 ` Cyril Hrubis
2025-09-22  8:24   ` Mark Wielaard
2025-09-22  8:33     ` Cyril Hrubis
2025-09-22 21:26       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918152640.1146279-1-mark@klomp.org \
    --to=mark@klomp.org \
    --cc=ltp@lists.linux.it \
    --cc=mcermak@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox