public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Introduce ioctl_pidfd_get_info_supported() function
Date: Tue, 23 Sep 2025 20:44:49 +0200	[thread overview]
Message-ID: <20250923184449.GA45748@pevik> (raw)
In-Reply-To: <20250923150337.19821-1-akumar@suse.de>

Hi Avinesh,

> use this routine in ioctl_pidfd05 before proceeding with the test

Reviewed-by: Petr Vorel <pvorel@suse.cz>

BTW, when testing on 6.11, I got:
ioctl_pidfd05.c:45: TFAIL: ioctl(pidfd, PIDFD_GET_INFO, NULL) expected EINVAL: ENOTTY (25)

Which is error unrelated to this patch, it's from original.
196988f7d1 ("Add ioctl_pidfd05 test")

Doc in ioctl_pidfd_info_exit_supported() is clear about it:
		/* - ENOTTY: old kernels not implementing fs/pidfs.c:pidfd_ioctl
		 * - EINVAL: until v6.13 kernel
		 * - ESRCH: all kernels between v6.13 and v6.15
		 */

But test happily ignores the fact :).

@Cyril do we want to fix it? Do we want to check for kernel versions or we just
take any of these values?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-09-23 18:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 20:39 [LTP] [PATCH] Introduce ioctl_pidfd_get_info_supported() function Avinesh Kumar
2025-09-22 21:07 ` Petr Vorel
2025-09-23  7:51   ` [LTP] [PATCH v2] " Avinesh Kumar
2025-09-23  9:43     ` Petr Vorel
2025-09-23 11:17     ` Cyril Hrubis
2025-09-23 11:39       ` Petr Vorel
2025-09-23 11:49         ` Cyril Hrubis
2025-09-23 15:03           ` [LTP] [PATCH v3] " Avinesh Kumar
2025-09-23 18:44             ` Petr Vorel [this message]
2025-09-24  8:40               ` Cyril Hrubis
2025-09-24 20:29                 ` [LTP] [PATCH v4] " Avinesh Kumar
2025-09-25  2:05                   ` Li Wang via ltp
2025-09-25  2:44                   ` Li Wang via ltp
2025-09-25  8:19                     ` [LTP] [PATCH v5] " Avinesh Kumar
2025-09-25 11:45                       ` Petr Vorel
2025-09-25 12:15                       ` Petr Vorel
2025-09-25  6:54                   ` [LTP] [PATCH v4] " Cyril Hrubis
2025-09-24  8:34             ` [LTP] [PATCH v3] " Cyril Hrubis
2025-09-24 20:30               ` Avinesh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250923184449.GA45748@pevik \
    --to=pvorel@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox