Re: [LTP] [PATCH v3] ioctl_loop01.c: Use proper device for partitioning

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > If we select option 2 then we have following setting for all related
> > test cases.
> > +       .needs_cmds = (const struct tst_cmd[]) {
> > +               {"parted", "0"},
> > +               {}
> > +       },

> > But how to get "parted" command support status? In ioctl_loop01.c there
> > is a local var "parted_sup" which flag parted command support or not, and
> > use this flag to decide which sub test needed. 
> > If we do this logic in test lib then we need create another
> > flag in tst_cmd used for give status of command support or not.
> > During test lib logic will set tst_cmd.support flag.

> >  struct tst_cmd {
> >  	const char *cmd;
> >  	unsigned int required:1;
> >  	unsigned int support:1;
> >  };

> > Correct me if any misunderstanding, many thanks.

> Sounds reasonable and we could also add a nice function to the test
> library:

> bool tst_cmd_present(const char *cmd);

> that would loop over the tst_cmd array and return the supported flag
> value.

+1, although not sure if we want to finish this before the release.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp