From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5] Introduce ioctl_pidfd_get_info_supported() function
Date: Thu, 25 Sep 2025 13:45:55 +0200 [thread overview]
Message-ID: <20250925114555.GA112008@pevik> (raw)
In-Reply-To: <20250925081912.14822-1-akumar@suse.de>
Hi Avinesh,
...
> +static inline int ioctl_pidfd_get_info_supported(void)
nit: I liked more the previous version v4, where 'bool' was used.
Actually both functions could use 'bool', but I'm perfectly ok with 'int'.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> +{
> + pid_t pid;
> + int pidfd, ret;
> + int supported = 0;
> + struct pidfd_info info;
> +
> + if (tst_kvercmp(6, 13, 0) >= 0)
> + return 1;
> +
> + memset(&info, 0, sizeof(struct pidfd_info));
> +
> + pid = SAFE_FORK();
> + if (!pid)
> + exit(100);
> +
> + pidfd = SAFE_PIDFD_OPEN(pid, 0);
> +
> + ret = ioctl(pidfd, PIDFD_GET_INFO, &info);
> + SAFE_WAITPID(pid, NULL, 0);
> +
> + if (ret != -1)
> + supported = 1;
> +
> + SAFE_CLOSE(pidfd);
> + return supported;
> +}
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-25 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 20:39 [LTP] [PATCH] Introduce ioctl_pidfd_get_info_supported() function Avinesh Kumar
2025-09-22 21:07 ` Petr Vorel
2025-09-23 7:51 ` [LTP] [PATCH v2] " Avinesh Kumar
2025-09-23 9:43 ` Petr Vorel
2025-09-23 11:17 ` Cyril Hrubis
2025-09-23 11:39 ` Petr Vorel
2025-09-23 11:49 ` Cyril Hrubis
2025-09-23 15:03 ` [LTP] [PATCH v3] " Avinesh Kumar
2025-09-23 18:44 ` Petr Vorel
2025-09-24 8:40 ` Cyril Hrubis
2025-09-24 20:29 ` [LTP] [PATCH v4] " Avinesh Kumar
2025-09-25 2:05 ` Li Wang via ltp
2025-09-25 2:44 ` Li Wang via ltp
2025-09-25 8:19 ` [LTP] [PATCH v5] " Avinesh Kumar
2025-09-25 11:45 ` Petr Vorel [this message]
2025-09-25 12:15 ` Petr Vorel
2025-09-25 6:54 ` [LTP] [PATCH v4] " Cyril Hrubis
2025-09-24 8:34 ` [LTP] [PATCH v3] " Cyril Hrubis
2025-09-24 20:30 ` Avinesh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925114555.GA112008@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox