From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] openposix: update invalid clock id to accomodate new auxiliary clock ids
Date: Tue, 7 Oct 2025 23:37:13 +0200 [thread overview]
Message-ID: <20251007213713.GB160168@pevik> (raw)
In-Reply-To: <6213145.lOV4Wx5bFT@thinkpad>
> On Tuesday, October 7, 2025 4:32:06 PM CEST Avinesh Kumar wrote:
> > Starting kernel v6.17, there are 8 more auxiliary clock ids reserved on
> > systems with CONFIG_POSIX_AUX_CLOCK=y [1] and moreover posix systems can
> > define and support any number of clocks beyond the mandatory ones.
> > [1] https://lore.kernel.org/lkml/20250519083025.905800695@linutronix.de/
> > Signed-off-by: Avinesh Kumar <akumar@suse.de>
> > ---
> > .../conformance/interfaces/clock_getres/6-2.c | 5 ++---
> > .../conformance/interfaces/clock_gettime/8-2.c | 4 ++--
> > .../conformance/interfaces/clock_settime/17-2.c | 4 ++--
> > 3 files changed, 6 insertions(+), 7 deletions(-)
> > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c b/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
> > index c44809012..af45e27c9 100644
> > --- a/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
> > +++ b/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
> > @@ -17,8 +17,7 @@
> > * unassigned value = -1073743192 (ex. of what gcc will set to)
> > * unassigned value = 1073743192 (ex. of what gcc will set to)
> > * -1
> > - * 17 (currently not = to any clock)
> > - *
> > + * 50 (hopefully big enough value not to be a valid clock id)
> > */
> > #include <stdio.h>
> > #include <time.h>
> > @@ -33,7 +32,7 @@ int main(void)
> > struct timespec res;
> > int invalid_tests[NUMINVALIDTESTS] = {
> > INT32_MIN, INT32_MAX, 2147483647, -2147483647, -1073743192,
> > - 1073743192, -1, 17
> > + 1073743192, -1, 50
> > };
> > int i;
> > int failure = 0;
> > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c b/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
> > index ed4cd4078..92263ce87 100644
> > --- a/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
> > +++ b/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
> > @@ -15,7 +15,7 @@
> > * unassigned value = -1073743192 (ex. of what gcc will set to)
> > * unassigned value = 1073743192 (ex. of what gcc will set to)
> > * -1
> > - * 17 (currently not = to any clock)
> > + * 50 (hopefully big enough value not to be a valid clock id)
> I see I added extra space in this one, please fix while merging if patch is fine.
Sure, np.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> Thanks,
> Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-10-07 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 10:13 [LTP] [PATCH] openposix: update invalid clock id to accomodate new auxiliary clock ids Avinesh Kumar
2025-10-03 10:25 ` Petr Vorel
2025-10-03 11:30 ` Avinesh Kumar
2025-10-03 12:26 ` Petr Vorel
2025-10-06 8:53 ` Cyril Hrubis
2025-10-06 9:08 ` Cyril Hrubis
2025-10-07 16:03 ` Avinesh Kumar
2025-10-06 9:43 ` Petr Vorel
2025-10-06 9:56 ` Cyril Hrubis
2025-10-07 14:32 ` [LTP] [PATCH v2] " Avinesh Kumar
2025-10-07 14:36 ` Avinesh Kumar
2025-10-07 21:37 ` Petr Vorel [this message]
2025-10-13 9:56 ` Andrea Cervesato via ltp
2025-10-13 11:29 ` Petr Vorel
2025-10-13 14:26 ` Petr Vorel
2025-10-13 14:11 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007213713.GB160168@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox