Re: [LTP] [PATCH v4] Remove TODO

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

> Changes in v4:
> - fix commit message
> - point to tst_run_shell.c
> - moved to developers
> - fix git grep command
> - Link to v3: https://lore.kernel.org/r/20251013-remove_todo-v3-1-533e47439a94@suse.com

Thanks!

...
> --- /dev/null
> +++ b/doc/developers/todo.rst
> @@ -0,0 +1,73 @@
> +.. SPDX-License-Identifier: GPL-2.0-or-later
> +
> +List of ongoing tasks
> +=====================
> +
> +This is a comprehensive list of tasks where LTP maintainers are currently
> +working on. Priorities might change over time, but these are the most important
> +points which are currently being achieved.
> +
> +Fade out old tests runner
> +-------------------------
> +
> +``runltp`` script is old and unmaintaned. We are slowly shifting to
nit: even this could be a link to script (to show newcomers the ugliness of the
script and the need to replace it :)).

:master:`runltp` script ..

> +`kirk <https://github.com/linux-test-project/kirk>`_, that will be our official
> +tests runner in the next future.

...
> +LTP maintainers are working on converting shell scripts to plain-C tests, in
> +order to reduce the impact that shell scripts might have on the overall kernel
> +testing.
> +
> +For a complete list of shell tests, please run the following command inside the
> +LTP root folder:
> +
> +.. code-block:: bash
> +
> +        git --no-pager grep -l -e '^\. .*_lib\.sh' -e '^\. .*test.sh'
> +
> +LTP also provides a shell loader implementation for plain-C tests using
> +:master:`testcases/lib/tst_run_shell.c`.

I would get wrong impression from this. Although shell loader allows have unique
tst_{res,brk} counter when mixing C and shell tests, it can be used for tests
solely written in shell. In that case the key point is to use LTP C library.

And when mixing C and shell, it's a shell test which uses C "test" (a tool which
uses C API). i.e. test driven by shell test.

Anyway, unless Cyril comes with it's own definition, I'm ok with this. We should
write a shell loader doc anyway and then it'll be linked here.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp