Re: [LTP] [PATCH 1/2] doc: Convert tst_kvercmp.h to RST

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > Could you please check my English.
> > @Cyril you're the author of the functions, please check my description.

Cyril, thanks a lot for a patient review and your points.

> Will do, btw some of the functions there are actually older than my
> involvement in LTP...
Lol :)

...
> > +/**
> > + * struct tst_kern_exv - describe vendor kernel.
> > + *
> > + * @dist_name: A distribution name, e.g. "SLES", "RHEL9", "UBUNTU"
> > + * @extra_ver: A vendor kernel version to check, e.g. "5.14.0-441".
> > + */
> >  struct tst_kern_exv {
> >  	char *dist_name;
> >  	char *extra_ver;
> >  };

> > +/**
> > + * tst_kvercmp2() - Compare given *distro* kernel version with the currently running kernel.
> > + *
> > + * @r1: Major kernel version.
> > + * @r2: Minor kernel version.
> > + * @r3: Kernel patch level.
> > + * @vers: struct tst_kern_exv.
>                                   ^
> The array has to be NULL dist_name terminated.

I don't understand "NULL dist_name". You mean array of NULL: { NULL, NULL}
Maybe say:
A NULL terminated array of struct tst_kern_exv.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp