Re: [LTP] [PATCH 1/2] ioctl_sg01: Skip USB devices

Petr Vorel
2025-10-22T13:37:47Z

Hi Martin,

> Hi Martin,

> > Some USB devices write hardware info and flags to the ioctl(SG_IO)
> > response buffer which results in test failure. But the info is constant
> > and doesn't represent any security risk. Skip USB devices to prevent
> > false positives.

> > ---

> > I've tested this patch on kernels v4.4 through v6.16. Non-USB generic SCSI
> > block devices get correctly found and used, USB block device get skipped.

> Thanks a lot for an extensive testing!

> I was also verify on my machine with block device connected over USB
> that it's skipped (and indeed test was blocked on master).

FYI running test with this HDD connected over USB no leaked info was printed (no
false positive), but test runs very slow (10 iterations in ~5 min, it will
likely manage below the limit, but 50x slower run is just waste of time given
vast majority of testers runs tests sequentially).

Kind regards,
Petr