Re: [LTP] [PATCH] file_attr02: Add XFS kernel config requirement

Anders Roxell
2025-10-27T14:33:16Z

On Mon, 27 Oct 2025 at 10:22, Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > > I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did
> > > not detect it. Could you please post whole output?
> > >
> > > Because if code in struct tst_test.filesystems does not work, many tests would
> > > be affected with this setup. I'm probably missing something, but I'd prefer to
> > > fix the detection in the library than force config (we don't have any CONFIG_.*_FS
> > > in testcases/).
>
> I think that we have a but in the test library, it looks like we do not
> check for the kernel support if we have only one filesystem defined in
> the tst_test.filesystems.
>
> The problem is that we are trying to avoid formatting and mounting the
> filesystem for each test iteration (if -i 10 is passed) but that means
> that we skip the filesystem kernel support. We only check for mkfs in
> the setup and prepare the device.
>
> This should fix it:

Indeed, this fixed the issue I tried it, for both file_attr02 and file_attr03.

Will you create a patch or do you want me to create one?

Cheers,
Anders