Re: [LTP] [PATCH] file_attr02: Add XFS kernel config requirement

Dan Carpenter
2025-10-24T17:26:04Z

On Fri, Oct 24, 2025 at 03:30:35PM +0200, Petr Vorel wrote:
> > The file_attr02 test requires XFS filesystem support to properly
> > test the FS_IOC_FSSETXATTR ioctl with project quotas. Add the
> > XFS kernel configuration requirement to ensure the test can run
> > on systems with XFS support either built-in or as a module.
>
> So you have problem on the kernel with CONFIG_XFS_FS=y?

No, on systems with CONFIG_XFS_FS=n. We do have the utilities
installed and FUSE_FS enabled, but the test says XFS is not
supported.

tst_supported_fs_types.c:129: TINFO: Filesystem xfs is not supported

The log file is here:
https://storage.tuxsuite.com/public/linaro/lkft/tests/340jmxk7fPGUn5zJbqsn4Chrs88/logs.txt

Both file_attr02 and file_attr03 fail.

> I wonder why tst_get_supported_fs_types() from lib/tst_supported_fs_types.c did
> not detect it. Could you please post whole output?
>
> Because if code in struct tst_test.filesystems does not work, many tests would
> be affected with this setup. I'm probably missing something, but I'd prefer to
> fix the detection in the library than force config (we don't have any CONFIG_.*_FS
> in testcases/).
>

That's a fair point. I'm not really very familiar with how LTP works.

On the other hand, even if we fixed the LTP framework to not run tests
on unsupported filesystems, we might want to still fix it in case someone
just ran it with kirk

./tools/kirk/kirk/kirk -c ./testcases/kernel/syscalls/file_attr/file_attr02

or even just directly `./file_attr02`

regards,
dan carpenter