Re: [LTP] [PATCH] thermal: add new test group

Petr Vorel
2025-11-06T16:50:42Z

Hi Piotr, Cyril,

> Hi!
> First of all, the tst_test.sh test library is in maitenance mode and new
> shell tests should use the tst_loader.sh instead. Have a look at the
> testcases/kernel/mem/vma/vma05.sh test on how does it look like.

Piotr, first thank you for submitting a test.

My wish would be no more shell based test. shell loader is kind of compromise to
improve existing shell based tests, but I'm not happy to see yet new more tests
in shell (we in SUSE will be then actively rewriting it into C :( to avoid
various problems with shell tests).

Piotr, would it be so hard to rewrite it into decent C?

C API has many helpers and it's more reliable:

https://github.com/linux-test-project/ltp/blob/master/doc/old/C-Test-API.asciidoc
https://linux-test-project.readthedocs.io/en/latest/developers/api_c_tests.html
https://linux-test-project.readthedocs.io/en/latest/developers/test_case_tutorial.html

+ many tests rewritten as a real code examples (see these which include "tst_test.h").

Also, do you plan to write only a single test? If yes I'm not sure if single
test deserves it's own scenario group.

Kind regards,
Petr