From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/5] swapon03: Don't create swap file twice
Date: Tue, 11 Nov 2025 16:24:14 +0100 [thread overview]
Message-ID: <20251111152414.GA61698@pevik> (raw)
In-Reply-To: <aRMxkqqQzgu40uqo@yuki.lan>
> Hi!
> > MAKE_SMALL_SWAPFILE(TEST_FILE) call is not needed, because the file is
> > created by is_swap_supported(TEST_FILE) call.
> I find it a bit ugly to depend on a leftover from is_swap_supported() to
> create the final swapfile. Maybe it would be cleaner to pass a path to
> an already created swapfile to the is_swap_supported() function instead
> so that the tests would create the file explicitly.
Sounds indeed better. I'll add it to my TODO list. Patchset could be rebased to
not include this for now.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-11-11 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:34 [LTP] [PATCH v2 0/5] swapon03: Try to swapon() as many files until it fails Petr Vorel
2025-11-06 16:34 ` [LTP] [PATCH v2 1/5] swapon03: Don't create swap file twice Petr Vorel
2025-11-11 12:52 ` Cyril Hrubis
2025-11-11 15:24 ` Petr Vorel [this message]
2025-11-06 16:34 ` [LTP] [PATCH v2 2/5] swapon03: Cleanup Petr Vorel
2025-11-11 13:04 ` Cyril Hrubis
2025-11-11 15:47 ` Petr Vorel
2025-11-06 16:34 ` [LTP] [PATCH v2 3/5] swapon03: Try to swapon() as many files until it fails Petr Vorel
2025-11-07 3:15 ` Li Wang via ltp
2025-11-11 13:07 ` Cyril Hrubis
2025-11-11 15:58 ` Petr Vorel
2025-11-11 16:03 ` Petr Vorel
2025-11-06 16:34 ` [LTP] [PATCH v2 4/5] libswap: Remove now unused tst_max_swapfiles() Petr Vorel
2025-11-06 16:35 ` [LTP] [PATCH v2 5/5] swapon03: Remove grep dependency Petr Vorel
2025-11-07 16:27 ` Avinesh Kumar
2025-11-14 10:24 ` Petr Vorel
2025-11-14 10:27 ` Cyril Hrubis
2025-11-14 12:09 ` Petr Vorel
2025-11-14 14:38 ` Cyril Hrubis
2025-11-18 12:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111152414.GA61698@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox