Re: [LTP] [PATCH v5] listmount04.c: Update case support mnt_id_req.mnt_ns_fd

Petr Vorel
2025-12-15T15:22:44Z

Hi Wei,

...
> > static inline ssize_t listmount(uint64_t mnt_id, uint64_t last_mnt_id,
> > uint64_t list[], size_t num, unsigned int flags)
> > {
> > - struct mnt_id_req req = {
> > - .size = MNT_ID_REQ_SIZE_VER0,
> > - .mnt_id = mnt_id,
> > - .param = last_mnt_id,
> > - };
> > + mnt_id_req *req = NULL;
> > + req->size = MNT_ID_REQ_SIZE_VER0;
> > + req->mnt_id = mnt_id;
> > + req->param = last_mnt_id;

> > return tst_syscall(__NR_listmount, &req, list, num, flags);
> Thanks for such detail feedback, will sent next patch.
> I guess we need s/&req/req/,
> or i think simple s/struct mnt_id_req/mnt_id_req/ more better.

Sure, just remove "struct" is way better, thanks!

Kind regards,
Petr

> > }