* [LTP] [PATCH] cgroup_xattr: Remove unused variable
@ 2025-12-09 13:54 Martin Doucha
2025-12-09 14:54 ` Andrea Cervesato via ltp
0 siblings, 1 reply; 3+ messages in thread
From: Martin Doucha @ 2025-12-09 13:54 UTC (permalink / raw)
To: ltp
The dir variable in mount_cgroup() is uninitialized but it gets
printed into error messages instead of the correct opt->dir. Remove
the variable and fix the error message.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c b/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
index 0d016b583..2c080933e 100644
--- a/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
+++ b/testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c
@@ -289,7 +289,6 @@ int mount_cgroup(void)
int i, any_mounted = 0;
for (i = 0; i < cgrp_opt_num; ++i) {
- char dir[MAX_DIR_NAME];
struct cgrp_option *opt = &cgrp_opt[i];
tst_resm(TINFO, "mount options %d: %s (hier = %d)",
i, opt->str, opt->hier);
@@ -297,7 +296,7 @@ int mount_cgroup(void)
SAFE_MKDIR(cleanup, opt->dir, 0755);
if (mount(opt->dir, opt->dir, "cgroup", 0, opt->str) == -1) {
- tst_resm(TINFO, "Can't mount: %s", dir);
+ tst_resm(TINFO, "Can't mount: %s", opt->dir);
continue;
}
--
2.51.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-09 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-09 13:54 [LTP] [PATCH] cgroup_xattr: Remove unused variable Martin Doucha
2025-12-09 14:54 ` Andrea Cervesato via ltp
2025-12-09 17:53 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox