public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Juerg Haefliger <juerg.haefliger@canonical.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] mkdir_tests.sh: Handle error message from mkdir from rust coreutils
Date: Tue, 9 Dec 2025 18:57:40 +0100	[thread overview]
Message-ID: <20251209175740.GC9500@pevik> (raw)
In-Reply-To: <20251209155726.519179-1-juerg.haefliger@canonical.com>

Hi Juerg,

> mkdir from rust coreutils doesn't print the directory path. Account for
> that.

> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  testcases/commands/mkdir/mkdir_tests.sh | 3 +++
>  1 file changed, 3 insertions(+)

> diff --git a/testcases/commands/mkdir/mkdir_tests.sh b/testcases/commands/mkdir/mkdir_tests.sh
> index c0a570e5c0e6..3bafbfdda7ba 100755
> --- a/testcases/commands/mkdir/mkdir_tests.sh
> +++ b/testcases/commands/mkdir/mkdir_tests.sh
> @@ -34,6 +34,9 @@ test2()

>  	if grep -q "$LONG_PATH.*No such file or directory" mkdir.out; then
>  		tst_res TPASS "Got correct error message"
> +	elif grep -q "mkdir: No such file or directory" mkdir.out; then
> +		# mkdir from rust coreutils doesn't print the directory path
> +		tst_res TPASS "Got correct error message"

I was thinking about using extended regular expressions to use a single check,
but it's more readable this way.

I wonder why rust folks did not want to follow coreutils in
this case.

Anyway, merged. Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2025-12-09 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 15:57 [LTP] [PATCH] mkdir_tests.sh: Handle error message from mkdir from rust coreutils Juerg Haefliger via ltp
2025-12-09 17:57 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251209175740.GC9500@pevik \
    --to=pvorel@suse.cz \
    --cc=juerg.haefliger@canonical.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox