Re: [LTP] [PATCH 1/2] cpuset_memory: Print basic subtest descriptions

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

> The cpuset_memory tests has multiple subtests. Print short description
> before each subtest to simplify debugging. The last three subtests
> have the same description because they differ only in the specific
> pattern of signals sent to the parent and child allocator threads.

Yeah, it makes sense as ith has 17 tests.

...
>  test16()
>  {
> +	tst_resm TINFO "Testing anonymous memory reallocation in multiple cpusets with threads and migration."

How about using $1 to print number of the test (on each message, not on the last
three)?
nit: Also, could we remove the trailing dot?

tst_resm TINFO "$1 Testing anonymous memory reallocation in multiple cpusets with threads and migration"

If you agree I can do both before merge.

Kind regards,
Petr

>  	cpuset_set "$CPUSET/1" "$cpu_of_node0" "1" "0" 2> $CPUSET_TMP/stderr
>  	if [ $? -ne 0 ]; then
>  		cpuset_log_error $CPUSET_TMP/stderr
> @@ -688,6 +704,7 @@ test16()

>  test17()
>  {
> +	tst_resm TINFO "Testing anonymous memory reallocation in multiple cpusets with threads and migration."
>  	cpuset_set "$CPUSET/1" "$cpu_of_node0" "1" "0" 2> $CPUSET_TMP/stderr
>  	if [ $? -ne 0 ]; then
>  		cpuset_log_error $CPUSET_TMP/stderr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp