From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/1] swapon03: Try to swapon() as many files until it fails
Date: Fri, 19 Dec 2025 15:03:56 +0100 [thread overview]
Message-ID: <20251219140356.GA187465@pevik> (raw)
In-Reply-To: <CAEemH2dwp0KUHpo+gVzBUNdDPJMo2xiZ59apHBWx=M_mmC7Y6g@mail.gmail.com>
> On Fri, Dec 19, 2025 at 6:47 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> > Hi!
> > > tst_res(TINFO, "Successfully created %d swap files", swapfiles);
> > > - MAKE_SMALL_SWAPFILE(TEST_FILE);
> > This should stay here, right? I suppose that the test works even when we
> > pass non-existing file in the verify_swapon() but we shouldn't bet on
> > that.
> Not exactly, I guess here deleted it because is_swap_supported(TEST_FILE)
> had already created the file but didn't clean it up in setup, so it still
> exists.
Yes.
> Or, we need to do is improve is_swap_supported(), remove the any test file,
> and then add it back separately.
My previous reply:
https://lore.kernel.org/ltp/20251219140216.GA247368@pevik/
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-12-19 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:42 [LTP] [PATCH v4 1/1] swapon03: Try to swapon() as many files until it fails Petr Vorel
2025-12-19 10:48 ` Cyril Hrubis
2025-12-19 12:41 ` Li Wang via ltp
2025-12-19 14:03 ` Petr Vorel [this message]
2025-12-19 14:04 ` Cyril Hrubis
2025-12-19 14:02 ` Petr Vorel
2025-12-19 14:41 ` Petr Vorel
2025-12-20 4:27 ` Li Wang via ltp
2025-12-20 4:32 ` Li Wang via ltp
2025-12-22 7:59 ` Petr Vorel
2025-12-22 8:55 ` Li Wang via ltp
2025-12-19 13:06 ` Li Wang via ltp
2025-12-19 14:18 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219140356.GA187465@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox