From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lio_listio_2-1: Rewrite test
Date: Thu, 15 Jan 2026 23:32:03 +0100 [thread overview]
Message-ID: <20260115223203.GA500939@pevik> (raw)
In-Reply-To: <20260115171847.28091-1-mdoucha@suse.cz>
Hi Martin,
LGTM, thank you!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> The test schedules multiple async writes into a file and then hopes that
> at least one will block long enough that a variable can be checked before
> the completion signal arrives. Use a socket pair instead of file
> to force async writes to block indefinitely. Then drain the socket after
> the first signal check and wait for the signal.
> Add cleanup helper function that will flush socket buffers, free allocated
> memory and close the sockets. Also make setup and cleanup simpler
> by statically allocating the aiocb structure array.
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> Another race condition fix by filling socket pair buffers until they
> block. Tested on kernel v4.4 and v6.12.
Tested on 6.17. (I was able to trigger "Error lio_listio() waited for list
completion" failure without the patch when running in loop, not with the patch).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-01-15 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 17:18 [LTP] [PATCH] lio_listio_2-1: Rewrite test Martin Doucha
2026-01-15 22:32 ` Petr Vorel [this message]
2026-01-16 12:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115223203.GA500939@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox