From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A22CBD3EE60 for ; Thu, 22 Jan 2026 13:07:04 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 37E3E3CB5C8 for ; Thu, 22 Jan 2026 14:07:03 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EF3D33CB3B1 for ; Thu, 22 Jan 2026 14:06:44 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 4A7211A00A54 for ; Thu, 22 Jan 2026 14:06:43 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 72090336D7; Thu, 22 Jan 2026 13:06:43 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2881913533; Thu, 22 Jan 2026 13:06:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ISD5A+IgcmlILQAAD6G6ig (envelope-from ); Thu, 22 Jan 2026 13:06:42 +0000 Date: Thu, 22 Jan 2026 14:06:34 +0100 From: Petr Vorel To: Li Wang Message-ID: <20260122130634.GA71214@pevik> References: <20260122102606.87754-1-liwang@redhat.com> <20260122123154.GC64562@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Queue-Id: 72090336D7 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] clone10: add support archs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Petr Vorel wrote: > > > Acked-by: Jan Stancek > > LGTM. Indeed only these 3 archs don't TCONF. > > Acked-by: Petr Vorel > > Out of curiosity, where is the support defined in kernel? > > "if (clone_flags & CLONE_SETTLS)" is in many archs: > Not based on this, the clone10.c test was written and gets tested > only on the known archs (x86_64, s390x, aarch64) by now. > And in case that other archs (not tested) have different behavior like i386, > so we are limited to the know/tested archs. > If we can get another arch to verified we can add it to the > .supported_archs as well. > $ cat -n ltp/include/lapi/tls.h > ... > 53 static inline void init_tls(void) > 54 { > 55 #if defined(__x86_64__) || defined(__aarch64__) || defined(__s390x__) > 56 tls_ptr = allocate_tls_area(); > 57 #else > ... include/lapi/tls.h static inline void init_tls(void) { #if defined(__x86_64__) || defined(__aarch64__) || defined(__s390x__) tls_ptr = allocate_tls_area(); #else tst_brk(TCONF, "Unsupported architecture for TLS"); #endif I see. First IMHO the message in include/lapi/tls.h is pretty misleading. It does not look to me as a test limitation, but as a missing arch support in kernel. IMHO the message should have been something like: tst_brk(TCONF, "Test not supported only architecture"); (i.e. to mention "test") Also having arch listed in the test and also in tls.h is redundant. IMHO it should be only on a single place. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp