Re: [LTP] [PATCH 2/3] metadata: metaparse: Add bool mappings to typemap

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

> - add all boolean flags in tst_test to the typemap

> - make typemap recursive (adds child pointer to the typemap struct)

> - add typemap mappings for the need_cmds optional key

> - change the implied tags to bool

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Later (after the release) it'd be nice to add a minimal doc (i.e. describe
structs in data_storage.h). I know that the usage is quite obvious when one has
knowledge of struct tst_test, but it's getting more complex (and will, because
if we want to get tst_net.sh support, at least getopts will need to be somehow
supported unless handled in shell).

...
>  	/* Normalize types */
> -	check_normalize_types(res);
> +	check_normalize_types(res, "",  tst_test_typemap);
very nit: 2 spaces.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp