From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50AE5D7237F for ; Fri, 23 Jan 2026 12:26:08 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E4ECB3CB779 for ; Fri, 23 Jan 2026 13:26:06 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 8F3183C3095 for ; Fri, 23 Jan 2026 13:25:48 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 0DA3160070B for ; Fri, 23 Jan 2026 13:25:47 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 971B85BCD3; Fri, 23 Jan 2026 12:25:47 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3376A136AA; Fri, 23 Jan 2026 12:25:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zsW6Cctoc2mRLAAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 12:25:47 +0000 Date: Fri, 23 Jan 2026 13:25:45 +0100 From: Petr Vorel To: Li Wang Message-ID: <20260123122545.GA122331@pevik> References: <20260123054056.131992-1-liwang@redhat.com> <20260123094538.GA113458@pevik> <20260123115317.GA117991@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Queue-Id: 971B85BCD3 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] userfaultfd05: handle kernels rejecting WP feature in UFFDIO_API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Ricardo Branco , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > > Yes, for the discussion when to use I'd propose to *not* use kconfig Maybe to correct myself: *Use* kconfig if there is no other way to detect the functionality [1]. We prefer to use kconfig detection, but do *not* use kconfig when there is another way to detect the functionality (e.g. via detecting functionality via /proc|sys) *and* and one of these three rules: > > * boot parameter to enable/disable exist * allow to disable via kernel boot parameter or via /sys file => because it can be disabled > > * check for tristate (functionality which can be compiled as module) => modul might not be available > > * kernel new functionality which is unlikely to be backported (use .min_kver instead) => probably faster > That sounds great to me. Thank you! > And, plus one more: > * kconfig file may be unavailable for some reasons Yes, but we gave up on this (or at least Cyril) [1]: As for the missing config there is 95 testcases that have needs_kconfigs set at this moment and the number is growing steadily. I would argue that you cannot run LTP without having config available. And the config location is autodetected on common distributions as well. me: + at least 2 IMA tests require kconfig via tst_require_kconfigs(). Therefore I accepted it and I'm not against using kconfig. But I would prefer using it only when it works reliably (100%). Kind regards, Petr [1] https://lore.kernel.org/ltp/aV6DCbns02E4BCTj@yuki.lan/ -- Mailing list info: https://lists.linux.it/listinfo/ltp