From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F6BCD35688 for ; Wed, 28 Jan 2026 07:25:12 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id AB6FA3CA660 for ; Wed, 28 Jan 2026 08:25:10 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 332493C5918 for ; Wed, 28 Jan 2026 08:24:51 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id CFE5E1400E15 for ; Wed, 28 Jan 2026 08:24:50 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4DBE45BCD1; Wed, 28 Jan 2026 07:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1769585087; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pd/qwnIAqBHnEpZnzKzIkOg3/L7BN+J1YTAi6coiT2o=; b=ZnYivHidOITsViFtALSydN67jCNKHRmMC6q3MiinjITV1hqS35DjqDBbq7k67PpInQL4G3 HqZVsyPaJ8PFKDXfZKwtIWURaRB516tQSc5EhalnJfR8Z/EpoJu8ct/W3MdMCMzeGL/VvR UV5VsdR9f9NeJAp4XtHr+NRZbwguGRM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1769585087; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pd/qwnIAqBHnEpZnzKzIkOg3/L7BN+J1YTAi6coiT2o=; b=Tz+goIz+9LI/X5zIdyNAtBiIRZ6ijrYvCDYA17gkHzymy+fg1Ufuqk2dC9pwtwJuFxlmw5 YtMzv0rD/kS46nDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1769585087; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pd/qwnIAqBHnEpZnzKzIkOg3/L7BN+J1YTAi6coiT2o=; b=ZnYivHidOITsViFtALSydN67jCNKHRmMC6q3MiinjITV1hqS35DjqDBbq7k67PpInQL4G3 HqZVsyPaJ8PFKDXfZKwtIWURaRB516tQSc5EhalnJfR8Z/EpoJu8ct/W3MdMCMzeGL/VvR UV5VsdR9f9NeJAp4XtHr+NRZbwguGRM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1769585087; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pd/qwnIAqBHnEpZnzKzIkOg3/L7BN+J1YTAi6coiT2o=; b=Tz+goIz+9LI/X5zIdyNAtBiIRZ6ijrYvCDYA17gkHzymy+fg1Ufuqk2dC9pwtwJuFxlmw5 YtMzv0rD/kS46nDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 161113EA61; Wed, 28 Jan 2026 07:24:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h3FmBL+5eWl7YgAAD6G6ig (envelope-from ); Wed, 28 Jan 2026 07:24:47 +0000 Date: Wed, 28 Jan 2026 08:24:45 +0100 From: Petr Vorel To: Jan Stancek , Cyril Hrubis , Terry Tritton , Andrea Cervesato , ltp@lists.linux.it, Andrea Cervesato , Li Wang Message-ID: <20260128072445.GB13495@pevik> References: <20251215161353.GA282302@pevik> <20251215165247.GC282302@pevik> <20260107160656.GB791855@pevik> <20260108133147.GB4263@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260108133147.GB4263@pevik> X-Spamd-Result: default: False [-3.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[7]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] ioctl_pidfd02-06: Add CONFIG_USER_NS and CONFIG_PID_NS to needs_kconfigs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" ... > > > > Because that was my question - really always prefer kconfig even there is a > > > > simple runtime solution? I'd like to have some "rule" like conclusion we can > > > > point during review. > > > I think that from a long term view this is going to be simpler solution > > > than having many different types of checks. The less diverse these > > > checks are the easier they are to review and maintain. Hence I lean > > > towards kernel config checks even though they are slower (mostly > > > unmeasurable on today's harware) than the alternatives. > > I think I lean opposite way, and rather have a check for right > > environment to support the test. > > You can have feature X enabled in kernel config, but still disabled > > later at boot/runtime > > (e.g. max_user_namespaces=0), or a module simply not being loaded. > +1, all "tristate" configured as module might be missing. (openSUSE JeOS suffers > with this when minimal kernel is installed). > But "bool" are safe unless depend on "tristate" configured as module (not the > case of CONFIG_USER_NS). > Kind regards, > Petr OK, it's a bool, let's merge it. I'm sorry to block it with a long discussion, but IMHO it was useful to bring some conclusion (I'm going to send a patch for rules). Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp