public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver
@ 2026-01-22 15:06 Kushal Chand K
  2026-01-28 21:03 ` Petr Vorel
  2026-01-29 10:34 ` Martin Doucha
  0 siblings, 2 replies; 5+ messages in thread
From: Kushal Chand K @ 2026-01-22 15:06 UTC (permalink / raw)
  To: ltp; +Cc: Kushal Chand K

This patch adds needs_driver field in kvm testcases to check for kvm driver

Signed-off-by: Kushal Chand K <kushalkataria5@gmail.com>
---
 testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
 testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
 testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
 testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
 7 files changed, 28 insertions(+)

diff --git a/testcases/kernel/kvm/kvm_pagefault01.c b/testcases/kernel/kvm/kvm_pagefault01.c
index db526cb7e..2b477f7af 100644
--- a/testcases/kernel/kvm/kvm_pagefault01.c
+++ b/testcases/kernel/kvm/kvm_pagefault01.c
@@ -165,6 +165,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		NULL
diff --git a/testcases/kernel/kvm/kvm_svm01.c b/testcases/kernel/kvm/kvm_svm01.c
index 32d15526b..f81602567 100644
--- a/testcases/kernel/kvm/kvm_svm01.c
+++ b/testcases/kernel/kvm/kvm_svm01.c
@@ -108,6 +108,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
diff --git a/testcases/kernel/kvm/kvm_svm02.c b/testcases/kernel/kvm/kvm_svm02.c
index 6914fdcba..701f2731d 100644
--- a/testcases/kernel/kvm/kvm_svm02.c
+++ b/testcases/kernel/kvm/kvm_svm02.c
@@ -129,6 +129,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
diff --git a/testcases/kernel/kvm/kvm_svm03.c b/testcases/kernel/kvm/kvm_svm03.c
index 87164d013..faafaf7cf 100644
--- a/testcases/kernel/kvm/kvm_svm03.c
+++ b/testcases/kernel/kvm/kvm_svm03.c
@@ -154,6 +154,10 @@ static struct tst_test test = {
 	.test_all = run,
 	.setup = setup,
 	.cleanup = cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.min_cpus = 2,
 	.supported_archs = (const char *const []) {
 		"x86_64",
diff --git a/testcases/kernel/kvm/kvm_svm04.c b/testcases/kernel/kvm/kvm_svm04.c
index 75fcbfdcf..af3c8b1c6 100644
--- a/testcases/kernel/kvm/kvm_svm04.c
+++ b/testcases/kernel/kvm/kvm_svm04.c
@@ -295,6 +295,10 @@ static struct tst_test test = {
 	.test_all = tst_kvm_run,
 	.setup = tst_kvm_setup,
 	.cleanup = tst_kvm_cleanup,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
diff --git a/testcases/kernel/kvm/kvm_vmx01.c b/testcases/kernel/kvm/kvm_vmx01.c
index 5bffbe946..d0c4913c9 100644
--- a/testcases/kernel/kvm/kvm_vmx01.c
+++ b/testcases/kernel/kvm/kvm_vmx01.c
@@ -269,6 +269,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
diff --git a/testcases/kernel/kvm/kvm_vmx02.c b/testcases/kernel/kvm/kvm_vmx02.c
index 3fcfebb3b..4ce225e56 100644
--- a/testcases/kernel/kvm/kvm_vmx02.c
+++ b/testcases/kernel/kvm/kvm_vmx02.c
@@ -183,6 +183,10 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = tst_kvm_cleanup,
 	.needs_root = 1,
+	.needs_drivers = (const char *const []) {
+		"kvm",
+		NULL
+	},
 	.supported_archs = (const char *const []) {
 		"x86_64",
 		"x86",
--
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver
  2026-01-22 15:06 [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver Kushal Chand K
@ 2026-01-28 21:03 ` Petr Vorel
  2026-01-29 10:38   ` Martin Doucha
  2026-01-29 10:34 ` Martin Doucha
  1 sibling, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2026-01-28 21:03 UTC (permalink / raw)
  To: Kushal Chand K; +Cc: Martin Doucha, ltp

Hi all,

> This patch adds needs_driver field in kvm testcases to check for kvm driver

@Kushal Thanks for your patch. very nit: s/needs_driver/needs_drivers/
(can be changed before merge).

Implements: https://github.com/linux-test-project/ltp/issues/1219

@Martin Is it enough to have kvm driver? Or do tests depend on any of specific
kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent
configs e.g.  CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

Kind regards,
Petr

> Signed-off-by: Kushal Chand K <kushalkataria5@gmail.com>
> ---
>  testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
>  testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
>  testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
>  testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
>  testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
>  testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
>  testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
>  7 files changed, 28 insertions(+)

> diff --git a/testcases/kernel/kvm/kvm_pagefault01.c b/testcases/kernel/kvm/kvm_pagefault01.c
> index db526cb7e..2b477f7af 100644
> --- a/testcases/kernel/kvm/kvm_pagefault01.c
> +++ b/testcases/kernel/kvm/kvm_pagefault01.c
> @@ -165,6 +165,10 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.cleanup = tst_kvm_cleanup,
>  	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		NULL
> diff --git a/testcases/kernel/kvm/kvm_svm01.c b/testcases/kernel/kvm/kvm_svm01.c
> index 32d15526b..f81602567 100644
> --- a/testcases/kernel/kvm/kvm_svm01.c
> +++ b/testcases/kernel/kvm/kvm_svm01.c
> @@ -108,6 +108,10 @@ static struct tst_test test = {
>  	.test_all = tst_kvm_run,
>  	.setup = tst_kvm_setup,
>  	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		"x86",
> diff --git a/testcases/kernel/kvm/kvm_svm02.c b/testcases/kernel/kvm/kvm_svm02.c
> index 6914fdcba..701f2731d 100644
> --- a/testcases/kernel/kvm/kvm_svm02.c
> +++ b/testcases/kernel/kvm/kvm_svm02.c
> @@ -129,6 +129,10 @@ static struct tst_test test = {
>  	.test_all = tst_kvm_run,
>  	.setup = tst_kvm_setup,
>  	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		"x86",
> diff --git a/testcases/kernel/kvm/kvm_svm03.c b/testcases/kernel/kvm/kvm_svm03.c
> index 87164d013..faafaf7cf 100644
> --- a/testcases/kernel/kvm/kvm_svm03.c
> +++ b/testcases/kernel/kvm/kvm_svm03.c
> @@ -154,6 +154,10 @@ static struct tst_test test = {
>  	.test_all = run,
>  	.setup = setup,
>  	.cleanup = cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.min_cpus = 2,
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
> diff --git a/testcases/kernel/kvm/kvm_svm04.c b/testcases/kernel/kvm/kvm_svm04.c
> index 75fcbfdcf..af3c8b1c6 100644
> --- a/testcases/kernel/kvm/kvm_svm04.c
> +++ b/testcases/kernel/kvm/kvm_svm04.c
> @@ -295,6 +295,10 @@ static struct tst_test test = {
>  	.test_all = tst_kvm_run,
>  	.setup = tst_kvm_setup,
>  	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		"x86",
> diff --git a/testcases/kernel/kvm/kvm_vmx01.c b/testcases/kernel/kvm/kvm_vmx01.c
> index 5bffbe946..d0c4913c9 100644
> --- a/testcases/kernel/kvm/kvm_vmx01.c
> +++ b/testcases/kernel/kvm/kvm_vmx01.c
> @@ -269,6 +269,10 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.cleanup = tst_kvm_cleanup,
>  	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		"x86",
> diff --git a/testcases/kernel/kvm/kvm_vmx02.c b/testcases/kernel/kvm/kvm_vmx02.c
> index 3fcfebb3b..4ce225e56 100644
> --- a/testcases/kernel/kvm/kvm_vmx02.c
> +++ b/testcases/kernel/kvm/kvm_vmx02.c
> @@ -183,6 +183,10 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.cleanup = tst_kvm_cleanup,
>  	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>  	.supported_archs = (const char *const []) {
>  		"x86_64",
>  		"x86",

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver
  2026-01-22 15:06 [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver Kushal Chand K
  2026-01-28 21:03 ` Petr Vorel
@ 2026-01-29 10:34 ` Martin Doucha
  1 sibling, 0 replies; 5+ messages in thread
From: Martin Doucha @ 2026-01-29 10:34 UTC (permalink / raw)
  To: Kushal Chand K, ltp

Hi!
Thanks for the patch.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 1/22/26 16:06, Kushal Chand K wrote:
> This patch adds needs_driver field in kvm testcases to check for kvm driver
> 
> Signed-off-by: Kushal Chand K <kushalkataria5@gmail.com>
> ---
>   testcases/kernel/kvm/kvm_pagefault01.c | 4 ++++
>   testcases/kernel/kvm/kvm_svm01.c       | 4 ++++
>   testcases/kernel/kvm/kvm_svm02.c       | 4 ++++
>   testcases/kernel/kvm/kvm_svm03.c       | 4 ++++
>   testcases/kernel/kvm/kvm_svm04.c       | 4 ++++
>   testcases/kernel/kvm/kvm_vmx01.c       | 4 ++++
>   testcases/kernel/kvm/kvm_vmx02.c       | 4 ++++
>   7 files changed, 28 insertions(+)
> 
> diff --git a/testcases/kernel/kvm/kvm_pagefault01.c b/testcases/kernel/kvm/kvm_pagefault01.c
> index db526cb7e..2b477f7af 100644
> --- a/testcases/kernel/kvm/kvm_pagefault01.c
> +++ b/testcases/kernel/kvm/kvm_pagefault01.c
> @@ -165,6 +165,10 @@ static struct tst_test test = {
>   	.setup = setup,
>   	.cleanup = tst_kvm_cleanup,
>   	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		NULL
> diff --git a/testcases/kernel/kvm/kvm_svm01.c b/testcases/kernel/kvm/kvm_svm01.c
> index 32d15526b..f81602567 100644
> --- a/testcases/kernel/kvm/kvm_svm01.c
> +++ b/testcases/kernel/kvm/kvm_svm01.c
> @@ -108,6 +108,10 @@ static struct tst_test test = {
>   	.test_all = tst_kvm_run,
>   	.setup = tst_kvm_setup,
>   	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		"x86",
> diff --git a/testcases/kernel/kvm/kvm_svm02.c b/testcases/kernel/kvm/kvm_svm02.c
> index 6914fdcba..701f2731d 100644
> --- a/testcases/kernel/kvm/kvm_svm02.c
> +++ b/testcases/kernel/kvm/kvm_svm02.c
> @@ -129,6 +129,10 @@ static struct tst_test test = {
>   	.test_all = tst_kvm_run,
>   	.setup = tst_kvm_setup,
>   	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		"x86",
> diff --git a/testcases/kernel/kvm/kvm_svm03.c b/testcases/kernel/kvm/kvm_svm03.c
> index 87164d013..faafaf7cf 100644
> --- a/testcases/kernel/kvm/kvm_svm03.c
> +++ b/testcases/kernel/kvm/kvm_svm03.c
> @@ -154,6 +154,10 @@ static struct tst_test test = {
>   	.test_all = run,
>   	.setup = setup,
>   	.cleanup = cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.min_cpus = 2,
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
> diff --git a/testcases/kernel/kvm/kvm_svm04.c b/testcases/kernel/kvm/kvm_svm04.c
> index 75fcbfdcf..af3c8b1c6 100644
> --- a/testcases/kernel/kvm/kvm_svm04.c
> +++ b/testcases/kernel/kvm/kvm_svm04.c
> @@ -295,6 +295,10 @@ static struct tst_test test = {
>   	.test_all = tst_kvm_run,
>   	.setup = tst_kvm_setup,
>   	.cleanup = tst_kvm_cleanup,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		"x86",
> diff --git a/testcases/kernel/kvm/kvm_vmx01.c b/testcases/kernel/kvm/kvm_vmx01.c
> index 5bffbe946..d0c4913c9 100644
> --- a/testcases/kernel/kvm/kvm_vmx01.c
> +++ b/testcases/kernel/kvm/kvm_vmx01.c
> @@ -269,6 +269,10 @@ static struct tst_test test = {
>   	.setup = setup,
>   	.cleanup = tst_kvm_cleanup,
>   	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		"x86",
> diff --git a/testcases/kernel/kvm/kvm_vmx02.c b/testcases/kernel/kvm/kvm_vmx02.c
> index 3fcfebb3b..4ce225e56 100644
> --- a/testcases/kernel/kvm/kvm_vmx02.c
> +++ b/testcases/kernel/kvm/kvm_vmx02.c
> @@ -183,6 +183,10 @@ static struct tst_test test = {
>   	.setup = setup,
>   	.cleanup = tst_kvm_cleanup,
>   	.needs_root = 1,
> +	.needs_drivers = (const char *const []) {
> +		"kvm",
> +		NULL
> +	},
>   	.supported_archs = (const char *const []) {
>   		"x86_64",
>   		"x86",
> --
> 2.43.0
> 
> 


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver
  2026-01-28 21:03 ` Petr Vorel
@ 2026-01-29 10:38   ` Martin Doucha
  2026-01-29 11:15     ` Petr Vorel
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Doucha @ 2026-01-29 10:38 UTC (permalink / raw)
  To: Petr Vorel, Kushal Chand K; +Cc: ltp

On 1/28/26 22:03, Petr Vorel wrote:
> Hi all,
> 
> @Martin Is it enough to have kvm driver? Or do tests depend on any of specific
> kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent
> configs e.g.  CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

Some KVM tests can be run by unprivileged user so those also need a 
check whether they have permission to open /dev/kvm for writing. But 
that can be fixed in a separate patch. Let's merge this one with the 
commit message fix.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver
  2026-01-29 10:38   ` Martin Doucha
@ 2026-01-29 11:15     ` Petr Vorel
  0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2026-01-29 11:15 UTC (permalink / raw)
  To: Martin Doucha; +Cc: Kushal Chand K, ltp

> On 1/28/26 22:03, Petr Vorel wrote:
> > Hi all,

> > @Martin Is it enough to have kvm driver? Or do tests depend on any of specific
> > kvm kernel config options (not only from virt/kvm/Kconfig, but arch dependent
> > configs e.g.  CONFIG_KVM_GUEST=y from arch/x86/Kconfig ?)

> Some KVM tests can be run by unprivileged user so those also need a check
> whether they have permission to open /dev/kvm for writing. But that can be
> fixed in a separate patch. Let's merge this one with the commit message fix.

+1, thank you!

Merged and I noted this TODO
https://github.com/linux-test-project/ltp/issues/1219#issuecomment-3817000775

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-29 11:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 15:06 [LTP] [PATCH v1] kvm: Add needs_driver support to check for kvm driver Kushal Chand K
2026-01-28 21:03 ` Petr Vorel
2026-01-29 10:38   ` Martin Doucha
2026-01-29 11:15     ` Petr Vorel
2026-01-29 10:34 ` Martin Doucha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox