Re: [LTP] [PATCH v2 2/2] include/old: rename legacy headers to tso_* namespace

[Petr Vorel <pvorel@suse.cz>]

Hi Li, all,

> To clearly distinguish legacy header files from the core (tst_*) and
> extension (tse_*) LTP APIs, legacy header files have been grouped
> into the otst_* namespace.

> Some legacy header files do not begin with old_, they still belong
> to the legacy header file set. For clarity, all legacy header files
> are now uniformly grouped into the tso_* namespace.

>  include/old/{old_checkpoint.h => tso_checkpoint.h}
>  include/old/{ltp_cpuid.h => tso_cpuid.h}
>  include/old/{old_device.h => tso_device.h}
>  include/old/{tlibio.h => tso_lio.h}
>  include/old/{old_module.h => tso_module.h}
>  include/old/{ltp_priv.h => tso_priv.h}
>  include/old/{random_range.h => tso_random_range.h}
>  include/old/{old_resource.h => tso_resource.h}
>  include/old/{old_safe_file_ops.h => tso_safe_file_ops.h}
>  include/old/{safe_macros.h => tso_safe_macros.h}
>  include/old/{old_safe_net.h => tso_safe_net.h}
>  include/old/{old_safe_stdio.h => tso_safe_stdio.h}
>  include/old/{ltp_signal.h => tso_signal.h}
>  include/old/{old_tmpdir.h => tso_tmpdir.h}
>  include/old/{usctest.h => tso_usctest.h}

As I wrote, I don't like the whole rename but I will not block it.
I guess it will be merged after the release, just not to break anything.

But is it worth to rename whole old API sources and headers? Isn't it enough
just to know that 'tst_' or 'tse_' are new API, the rest is the old API or no
API? Each rename means that 'git log' requires '--' because the rename.

Anyway, IMHO it would help (as a separate effort after the release) to describe
the prefixes in doc.

Kind regards,
Petr

> No functional changes intended.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp