Re: [LTP] [PATCH v2 2/2] include/old: rename legacy headers to tso_* namespace

[Petr Vorel <pvorel@suse.cz>]

Hi Li, all,

> > As I wrote, I don't like the whole rename but I will not block it.
> > I guess it will be merged after the release, just not to break anything.

> > But is it worth to rename whole old API sources and headers? Isn't it
> > enough
> > just to know that 'tst_' or 'tse_' are new API, the rest is the old API or
> > no
> > API? Each rename means that 'git log' requires '--' because the rename.


> Well, yes, that's my hesitation too.

> However, I believe the old APIs may persist for a long time. Therefore,
> using consistent naming conventions for all APIs will make it easier for
> LTP beginners to understand the code logic.

OK. Ack for both commits.
Acked-by: Petr Vorel <pvorel@suse.cz>

> > Anyway, IMHO it would help (as a separate effort after the release) to
> > describe
> > the prefixes in doc.


> Yes, it's not a rush, we could give enough time for refinement work.

+1

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp