From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80EF7D73EA9 for ; Fri, 30 Jan 2026 00:27:42 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 261383CBEDC for ; Fri, 30 Jan 2026 01:27:41 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E31FE3CB429 for ; Fri, 30 Jan 2026 01:27:22 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 26D3A20015B for ; Fri, 30 Jan 2026 01:27:21 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73C945BCF3; Fri, 30 Jan 2026 00:27:21 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0BED23EA61; Fri, 30 Jan 2026 00:27:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h078Aen6e2mKfAAAD6G6ig (envelope-from ); Fri, 30 Jan 2026 00:27:21 +0000 Date: Fri, 30 Jan 2026 01:27:19 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: <20260130002719.GB120546@pevik> References: <20251215161353.GA282302@pevik> <20251215165247.GC282302@pevik> <20260107160656.GB791855@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 73C945BCF3 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] ioctl_pidfd02-06: Add CONFIG_USER_NS and CONFIG_PID_NS to needs_kconfigs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Ricardo Branco , Martin Doucha , ltp@lists.linux.it, Terry Tritton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, [ Cc Martin ] > Hi! > > > > Because that was my question - really always prefer kconfig even there is a > > > > simple runtime solution? I'd like to have some "rule" like conclusion we can > > > > point during review. > > > I think that from a long term view this is going to be simpler solution > > > than having many different types of checks. The less diverse these > > > checks are the easier they are to review and maintain. Hence I lean > > > towards kernel config checks even though they are slower (mostly > > > unmeasurable on today's harware) than the alternatives. > > I think I lean opposite way, and rather have a check for right > > environment to support the test. > > You can have feature X enabled in kernel config, but still disabled > > later at boot/runtime > > (e.g. max_user_namespaces=0), or a module simply not being loaded. > That is a good catch. > Maybe the best way forward would be to add hooks for certain config > options into the LTP kernel config parser that would do additional > runtime checks. That way we would have both the information on which > kernel configs should be enabled in test metadata as well as runtime > checks. I like the idea: having metadata doc + runtime check is nice. FYI (I know you all watch GitHub PR but just in case) to document that for some tests require more things to check, e.g. kconfig + min_kver: https://github.com/linux-test-project/ltp/pull/1285 Kind regards, Petr > What about eventually adding something as: > diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c > index 9bcd57721..f6abe6cc7 100644 > --- a/lib/tst_kconfig.c > +++ b/lib/tst_kconfig.c > @@ -110,6 +110,18 @@ static void close_kconfig(FILE *fp) > fclose(fp); > } > +static void runtime_check(struct tst_kconfig_var *var) > +{ > + if (strstr(var->id, "CONFIG_USER_NS")) { > + if (!tst_user_ns_enabled()) { > + tst_res(TINFO, "CONFIG_USER_NS present but runtime is disabled"); > + var->val = 'n'; > + } > + } else if (...) > + ... > + } > +} > + > static inline int kconfig_parse_line(const char *line, > struct tst_kconfig_var *vars, > unsigned int vars_len) > @@ -183,9 +195,11 @@ out: > switch (val[0]) { > case 'y': > vars[i].choice = 'y'; > + runtime_check(&vars[i]); > return 1; > case 'm': > vars[i].choice = 'm'; > + runtime_check(&vars[i]); > return 1; > } > } -- Mailing list info: https://lists.linux.it/listinfo/ltp