public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>,
	Tim Bird <Tim.Bird@sony.com>, Julien Olivain <ju.o@free.fr>,
	ltp@lists.linux.it, automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [PATCH 4/4] kirk: Remove runltp-ng symlink
Date: Wed, 4 Feb 2026 13:46:40 +0100	[thread overview]
Message-ID: <20260204124640.GA244528@pevik> (raw)
In-Reply-To: <DG664MTNCKXU.10ZGQ5CGF7DC9@suse.com>

Hi Andrea, all,
> Hi!

> On Wed Feb 4, 2026 at 12:53 PM CET, Petr Vorel wrote:
> > kirk is here long enough to remove the symlink.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  tools/kirk/Makefile | 2 --
> >  1 file changed, 2 deletions(-)

> > diff --git a/tools/kirk/Makefile b/tools/kirk/Makefile
> > index 876eb3e2ed..859afde6e6 100644
> > --- a/tools/kirk/Makefile
> > +++ b/tools/kirk/Makefile
> > @@ -17,8 +17,6 @@ ifneq ($(wildcard $(abs_srcdir)/kirk-src/libkirk/*.py),)
> >  	install -m 00644 $(abs_srcdir)/kirk-src/libkirk/*.py $(BASE_DIR)/libkirk
> >  	install -m 00644 $(abs_srcdir)/kirk-src/libkirk/channels/*.py $(BASE_DIR)/libkirk/channels
> >  	install -m 00775 $(abs_srcdir)/kirk-src/kirk $(BASE_DIR)/kirk
> > -
> > -	cd $(BASE_DIR) && ln -sf kirk runltp-ng
> >  endif

> >  include $(top_srcdir)/include/mk/generic_leaf_target.mk

> This is the only point where im not 100% sure. I'm wondering if we
> should keep a symlink to `runltp`, just in case people will have CI
> working on LTP.

I'm not sure if hiding 'kirk' under 'runltp' symlink is a good idea. If yes,
there should be a big warning if people run it via symlink (detect in
kirk-src/kirk that it was run via 'runltp').

Do you agree with removing 'runltp-ng' symlink?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-02-04 12:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 11:53 [LTP] [PATCH 0/4] Remove runltp Petr Vorel
2026-02-04 11:53 ` [LTP] [PATCH 1/4] doc: INSTALL: dma_thread_diotest.c: Remove runltp from doc Petr Vorel
2026-02-04 11:53 ` [LTP] [PATCH 2/4] testscripts/lvmtest.sh: Replace runltp with kirk Petr Vorel
2026-02-04 11:53 ` [LTP] [PATCH 3/4] runltp: Remove Petr Vorel
2026-02-04 13:15   ` Li Wang via ltp
2026-02-04 13:21     ` Petr Vorel
2026-02-04 13:27       ` Cyril Hrubis
2026-02-04 13:28         ` Li Wang via ltp
2026-02-04 22:36         ` Petr Vorel
2026-02-04 13:32     ` Andrea Cervesato via ltp
2026-02-04 11:53 ` [LTP] [PATCH 4/4] kirk: Remove runltp-ng symlink Petr Vorel
2026-02-04 12:15   ` Andrea Cervesato via ltp
2026-02-04 12:46     ` Petr Vorel [this message]
2026-02-04 13:45       ` Andrea Cervesato via ltp
2026-02-04 16:59         ` Petr Vorel
2026-02-04 12:59 ` [LTP] [PATCH 0/4] Remove runltp Cyril Hrubis
2026-02-04 22:38   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204124640.GA244528@pevik \
    --to=pvorel@suse.cz \
    --cc=Tim.Bird@sony.com \
    --cc=andrea.cervesato@suse.com \
    --cc=automated-testing@lists.yoctoproject.org \
    --cc=ju.o@free.fr \
    --cc=ltp@lists.linux.it \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vasileios.almpanis@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox