From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 011CCEC1E94 for ; Thu, 5 Feb 2026 10:25:30 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 77F8B3CE420 for ; Thu, 5 Feb 2026 11:25:29 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D14033C2F6A for ; Thu, 5 Feb 2026 11:25:12 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 4FB0360073C for ; Thu, 5 Feb 2026 11:25:12 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A0C933E78A; Thu, 5 Feb 2026 10:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1770287111; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJGQXdO1n1qAR3UKOSFun+QycrWFlmjQetJGgkrM9jg=; b=lMFOtYm3JCFyNjvHJqA5i9ShT7QwOyz6u2L4YHZU8jd6pYdbHXjOZU7hfZqXnyibSkKNi5 J8+FY3KYS8tdRB/BvL3v6vnevbSu8PP2uvrT6/yR6BZdlD8duFmJKninwrfNPu3ZBLcdBS fbH0S+hAQrA/0+PzLVILZIZaq4nwmQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1770287111; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJGQXdO1n1qAR3UKOSFun+QycrWFlmjQetJGgkrM9jg=; b=NKk/7vJ5sh6hMmDjQGulubgzDOquG+HGH+wmyIg1IUbDyZfje1LAgzeikoIjxAvBTmKrut 5Inyzdq7HX6dleDQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1770287111; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJGQXdO1n1qAR3UKOSFun+QycrWFlmjQetJGgkrM9jg=; b=lMFOtYm3JCFyNjvHJqA5i9ShT7QwOyz6u2L4YHZU8jd6pYdbHXjOZU7hfZqXnyibSkKNi5 J8+FY3KYS8tdRB/BvL3v6vnevbSu8PP2uvrT6/yR6BZdlD8duFmJKninwrfNPu3ZBLcdBS fbH0S+hAQrA/0+PzLVILZIZaq4nwmQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1770287111; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJGQXdO1n1qAR3UKOSFun+QycrWFlmjQetJGgkrM9jg=; b=NKk/7vJ5sh6hMmDjQGulubgzDOquG+HGH+wmyIg1IUbDyZfje1LAgzeikoIjxAvBTmKrut 5Inyzdq7HX6dleDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7E4B63EA63; Thu, 5 Feb 2026 10:25:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zx7rHQdwhGkODwAAD6G6ig (envelope-from ); Thu, 05 Feb 2026 10:25:11 +0000 Date: Thu, 5 Feb 2026 11:25:10 +0100 From: Petr Vorel To: Li Wang Message-ID: <20260205102510.GC294817@pevik> References: <20260204124323.244578-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-7.50 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] openat2: Move includes to lapi, remove _GNU_SOURCE X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On Thu, Feb 05, 2026 at 02:08:42PM +0800, Li Wang wrote: > > On Wed, Feb 04, 2026 at 01:43:23PM +0100, Petr Vorel wrote: > > > Improve 767b3e519e. struct open_how is also used in lapi/openat2.h, > > > which is used by all openat2*.c tests. Therefore move to the > > > lapi header (and use lapi/fcntl.h instead). > > > Also remove _GNU_SOURCE which should not be needed. > > > While at it, move include "config.h" to the top. > > > Signed-off-by: Petr Vorel > > > --- > > > Hi Li, > > > my points from the original patchset why not use _GNU_SOURCE: > > > glibc test tst-openat2.c [1] which includes , uses struct > > Interesting, I haven't figure out why it can be built within glibc itself. > I think that becuase it uses '-D_GNU_SOURCE' cflags has already globally > enabled the GNU extension (equivalent to '#define _GNU_SOURCE'), which is > done uniformly by glibc's build system. Interesting, I did not know they compile tree with _GNU_SOURCE. > glibc/Makerules: ALL_BUILD_CFLAGS = $(BUILD_CFLAGS) $(BUILD_CPPFLAGS) -D_GNU_SOURCE \ > -DIS_IN_build -include $(common-objpfx)config.h Yes, -D is equivalent to #define. IMHO it's better to use #define _GNU_SOURCE (more obvious than command line switch). > To verify this, when I add the '-D_GNU_SOURCE' cflgs in the LTP/openat20*.c > compliation, it build succeed as well: > # gcc -I../../../../include -I../../../../include \ > -I../../../../include/old/ -Wformat -Werror=format-security \ > -Werror=implicit-function-declaration -Werror=return-type -fno-common \ > -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition \ > -D_GNU_SOURCE \ > -std=gnu99 -L../../../../lib openat202.c -lltp -o openat202 > So, to this patch, we need to add the _GNU_SOURCE definition. Thanks for investigating, I'm sorry for bothering with it. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp