From: Petr Vorel <pvorel@suse.cz>
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] add ETH_P_CAN compat macro to LAPI headers
Date: Fri, 6 Feb 2026 15:34:08 +0100 [thread overview]
Message-ID: <20260206143408.GA402479@pevik> (raw)
In-Reply-To: <20260206125818.319190-2-vasileios.almpanis@virtuozzo.com>
Hi Vasileios,
> include/lapi/if_ether.h | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/include/lapi/if_ether.h b/include/lapi/if_ether.h
> index 536d1863a..423341c57 100644
> --- a/include/lapi/if_ether.h
> +++ b/include/lapi/if_ether.h
> @@ -16,4 +16,8 @@
> # define ETH_P_ALL 0x0003
> #endif
> +#ifndef ETH_P_CAN
> +# define ETH_P_CAN 0x000C
> +#endif
This is not needed, because it was added to kernel's
include/uapi/linux/if_ether.h before UAPI creation in v3.7-rc1.
And we now expect kernel >= 4.4 [1].
FYI the fallback was originally added in 2017 in
db141701dd ("Add test for CVE-2017-7308 on a raw socket's ring buffer"),
the supported systems required it back then, but now whole include/lapi/if_ether.h,
could be deleted (as an separate effort). For now it'd be enough just to ignore
this commit (not add it).
Kind regards,
Petr
[1] https://linux-test-project.readthedocs.io/en/latest/users/supported_systems.html
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-02-06 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:51 [LTP] [PATCH 0/2] pty: use correct protocol in pty04 based on line discipline Vasileios Almpanis via ltp
2026-02-06 12:51 ` [LTP] [PATCH 1/2] add ETH_P_CAN compat macro to LAPI headers Vasileios Almpanis via ltp
2026-02-06 14:34 ` Petr Vorel [this message]
2026-02-06 12:51 ` [LTP] [PATCH 2/2] pty04: use the correct protocol per line discipline to avoid extra packets Vasileios Almpanis via ltp
2026-02-06 14:39 ` Petr Vorel
2026-02-11 16:44 ` Martin Doucha
2026-02-06 14:36 ` [LTP] [PATCH 0/2] pty: use correct protocol in pty04 based on line discipline Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206143408.GA402479@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox