From: Jinseok Kim <always.starving0@gmail.com>
To: chrubis@suse.cz, ltp@lists.linux.it
Subject: [LTP] [PATCH] open: fix directory verification and misleading test description
Date: Thu, 19 Feb 2026 23:57:17 +0900 [thread overview]
Message-ID: <20260219145719.6660-1-always.starving0@gmail.com> (raw)
In-Reply-To: <aZbmf5tEKC75gH7T@yuki.lan>
Hi, Hrubis
Thanks for the review.
I checked fstat/:
None of the existing fstat tests actually verify file type bits as you
suggested.
I think the cleanest solution is to introduce a new test `fstat04.c`
that creates different file types (regular, directory, character, etc.)
and explicitly checks `S_ISREG()`, `S_ISDIR()`, `S_ISCHR()` and so on.
How do you think about removing the O_DIRECTORY case from open01.c and
creating a separate fstat test?
Thanks again,
Jinseok.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-02-19 14:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 17:16 [LTP] [PATCH] open: fix directory verification and misleading test description Jinseok Kim
2026-02-17 13:21 ` Andrea Cervesato via ltp
2026-02-19 10:31 ` Cyril Hrubis
2026-02-19 14:57 ` Jinseok Kim [this message]
2026-02-20 10:49 ` Cyril Hrubis
2026-02-24 7:37 ` [LTP] [PATCH 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-02-24 7:37 ` [LTP] [PATCH 2/2] Add test for multiple file types using fstat Jinseok Kim
2026-02-24 8:17 ` [LTP] [PATCH 1/2] open: remove O_DIRECTORY case (move to fstat test) Andrea Cervesato via ltp
2026-02-24 10:07 ` [LTP] [PATCH v2 " Jinseok Kim
2026-02-24 10:07 ` [LTP] [PATCH v2 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-02-24 14:17 ` Andrea Cervesato via ltp
2026-02-25 13:19 ` [LTP] [PATCH v3 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-02-25 13:19 ` [LTP] [PATCH v3 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-02-25 14:30 ` Andrea Cervesato via ltp
2026-02-26 15:32 ` Jinseok Kim
2026-02-26 15:44 ` Andrea Cervesato via ltp
2026-03-03 13:32 ` [LTP] [PATCH v4 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-03-03 13:32 ` [LTP] [PATCH v4 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-12 11:22 ` Andrea Cervesato via ltp
2026-03-13 14:07 ` Jinseok Kim
2026-03-13 15:36 ` Andrea Cervesato via ltp
2026-03-15 7:27 ` [LTP] [PATCH v5 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-03-15 7:27 ` [LTP] [PATCH v5 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-16 7:38 ` [LTP] [PATCH v5 1/2] open: remove O_DIRECTORY case (move to fstat test) Andrea Cervesato via ltp
2026-03-16 15:00 ` [LTP] [PATCH v6 " Jinseok Kim
2026-03-16 15:00 ` [LTP] [PATCH v6 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-24 12:17 ` Andrea Cervesato via ltp
2026-03-27 15:27 ` [LTP] [PATCH v7] " Jinseok Kim
2026-03-30 8:07 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219145719.6660-1-always.starving0@gmail.com \
--to=always.starving0@gmail.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox