public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 1/1] [STAGING] ioctl_pidfd06: accept EREMOTE/ESRCH for PIDFD_GET_INFO across pidns
Date: Fri, 20 Feb 2026 12:33:42 +0100	[thread overview]
Message-ID: <20260220113342.GA382770@pevik> (raw)
In-Reply-To: <aZg8FeATSABAhBfw@yuki.lan>

...
> > +static const int exp_errnos[] = {EREMOTE, ESRCH};

> >  static void run(void)
> >  {
> > @@ -41,7 +42,8 @@ static void run(void)
> >  	args->exit_signal = SIGCHLD;


> I would be stricter for new kernels, we do not want the new value
> reverted back by an accident. So what about:

So we might want to add this to ground rules.

> static int err_nr = ARRAY_SIZE(exp_errnos);

> static void setup(void)
> {
> 	...
> 	if (tst_kvercmp(9, 19, 0) >= 0)
> 		err_nr = 1;
> 	...
> }

+1

> >  	if (!SAFE_CLONE(args)) {
> > -		TST_EXP_FAIL(ioctl(pidfd, PIDFD_GET_INFO, info), ESRCH);
> > +		TST_EXP_FAIL_ARR(ioctl(pidfd, PIDFD_GET_INFO, info), exp_errnos,
> > +				ARRAY_SIZE(exp_errnos));
> 				^
> 				err_nr

+1

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-02-20 11:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 16:30 [LTP] [PATCH v2 1/1] [STAGING] ioctl_pidfd06: accept EREMOTE/ESRCH for PIDFD_GET_INFO across pidns Jan Polensky
2026-02-19 20:06 ` Petr Vorel
2026-02-20 10:08 ` Andrea Cervesato via ltp
2026-02-20 10:48 ` Cyril Hrubis
2026-02-20 11:33   ` Petr Vorel [this message]
2026-02-20 15:05   ` Jan Polensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220113342.GA382770@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox