Re: [LTP] [PATCH v2 1/6] doc: INSTALL: dma_thread_diotest.c: Remove runltp from doc

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > > @@ -105,9 +105,9 @@ Quick Start
> > > >  	$ ./configure
> > > >  	$ make all
> > > >  	# make install
> > >         ^
> > > 	This should be $ (not caused by this patch but worth fixing)

> > I can change it, but IMHO for creating /opt/ltp is needed to run it as root
> > for a first time. Or one must chmod/chown /opt/ltp under root.

> Huh? The make install should just work fine. I'm just pointing out the
> typo # vs $. Or did I miss something?

Yeah, I understand it and plan to change # => $. I talked about /opt (our
default prefix) usually not being writable by regular users (installing any
software using standard system prefix will have this problem). Root is needed
only for creating /opt/ltp. That was the reason for the original user to use '#'.
But as I wrote, I'm ok to change the prompt.

> > > > -	$ /opt/ltp/runltp

> > > >  *NOTE:
> > > > +- For running tests use kirk [1], individual test you can run directly.
> > >                                                     ^
> > > 					 This sentece has wrong order of words.

> > > And also oversimplifies things, there is no mention of setting correct
> > > PATH that needs to be done in order to run these tests.

> > > I would just drop that and leave only the first sentence.

> > Sure, I can remove it:

> > +++ INSTALL
> > @@ -107,7 +107,7 @@ Quick Start
> >  	# make install

> >  *NOTE:
> > -- For running tests use kirk [1], individual test you can run directly.
> > +- For running tests use kirk [1].
> >  - LTP assumes the existence of the nobody, bin, and daemon users and their
> >  groups.  If these IDs do not exist, certain tests will fail. The respective
> >  user and group IDs should be the same, i.e. if `nobody's' user ID is 99, then
> > ---
> > If I'm correct this is likely the only change. Can you add your RBT and I modify
> > before merge?

> Once we agree on the # vs $.

+1

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp