Re: [LTP] [PATCH] nfs: Adapt the lib to allow to test in 2-host mode

[Petr Vorel <pvorel@suse.cz>]

Hi Sebastian,

...
> > ... if you remove exportfs from TST_NEEDS_CMDS you can use the same code
> > for
> > both netns and 2 based setup (tst_rhost_run should work well on netns).


> good point. I have tested v2 which I will send shortly.

+1

> > I was thinking about having a special variable for checking rhost only, but
> > given that tst_test.sh is now also deprecated, we will have to solve this
> > in
> > shell loader.

> I was also thinking about it but in the end I think it could be just yet
> another variable to control the test flow, so one more thing
> to worry about... and as far as I see relying on the presence of already
> defined variables seems good enough.

Until shell loader came I thought we'd parse tests which use tst_test.sh
(I thought therefore these variables would be used in metadata).

Now I'm thinking whether write the minimal tst_net.sh functionality directly in C
as either new library (code in libs/) or just core library extension (lib/*.c).
For sure it'd be quicker just to put subset of required code into new script,
but it's worth to consider it. That would also help rewrite tests in C in the
future.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp