Re: [LTP] [PATCH v10] thermal: add new test group

[Petr Vorel <pvorel@suse.cz>]

Hi Piotr, all,

I like the runtime drastically speedup :).

...
> +static void cleanup(void)
> +{
> +	if (x86_pkg_temp_tz_found)
> +		SAFE_FILE_PRINTF(trip_path, "%d", trip);


We discussed EINVAL error on a first run in [1]
thermal_interrupt_events.c:178: TWARN: Failed to close FILE '/sys/class/thermal/thermal_zone1/trip_point_1_temp': EINVAL (22)

This happens in safe_file_vprintf(), just TBROK is converted to TWARN due being
in cleanup(). I wonder if separate test for this would be useful.

You pointed a kernel fix [2] bug git hash changed (now cgit shows Bad commit
"reference: 39b1bd1613b8f73994f654988ad75a72b633f5e2"). Do you know the new hash
of the fix? Maybe putting the hash info in the test would be useful

	.tags = (const struct tst_tag[]) {
			{"linux-git", "..."}, // hash of the fix
			{}

nit (we discussed it in the past): when x86_pkg_temp_tz_found is bool, instead
of using 1:
x86_pkg_temp_tz_found = 1;
would be cleaner to use true.

Otherwise LGTM now.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/20260121230639.GA10001@pevik/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/patch/?id=39b1bd1613b8f73994f654988ad75a72b633f5e2

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp