From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 266BEE9B37D for ; Mon, 2 Mar 2026 13:45:31 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B3B443D79FE for ; Mon, 2 Mar 2026 14:45:29 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id DFCE03D0666 for ; Mon, 2 Mar 2026 14:45:09 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 43AF76002AC for ; Mon, 2 Mar 2026 14:45:09 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E7B885BD52; Mon, 2 Mar 2026 13:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772459108; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T49F5jPJX2q7DInCRH1cspXOpfgn7xDVAAqlj21pR0s=; b=aK/yQjEiahRig33humAs+eK3PIwqWMzlSj6jFnR3/WWFxTuiGTx/GVX2bo99RBWLbLSZBk JhNCM8a6Ep8wLdO+cqbiO3EnnvFz1tBFrVcs3v9M+L+HUQRYmQFi9lo2AV32Xi8bN7LNz4 LziLWLRegHP0eXcomFx3yP92Rdb7/cQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772459108; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T49F5jPJX2q7DInCRH1cspXOpfgn7xDVAAqlj21pR0s=; b=nDKTiV3NYYsecGRVvg36HASrdPEW4H7h269Zf2KomVYvIX1A2uGD2/pA888pyVEApfxBD2 b3Zgu6Bd60zUCBBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1772459107; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T49F5jPJX2q7DInCRH1cspXOpfgn7xDVAAqlj21pR0s=; b=F/OS6n6Jt/x7bFcK7C6UxccX1qrJrh3NHgyaqHX539Vj/J3KLxIEuS6BetmdrdKGdCnvZG hqimahP1WNGWX/CsBrUjSdvA9VqdGc8QOpAewsPrysVc/6AdR+6wmxBiqeeGUCp7JOdD1j 0CldVaLeW+NsccUokoAxl6fL9oKuZN4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1772459107; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T49F5jPJX2q7DInCRH1cspXOpfgn7xDVAAqlj21pR0s=; b=8U1rEbH951OXEFvSn/XGsjG2q1BUSJLoqflt4PMqtcZUZMrDN7dw5tHIfcQRf6oeu64RtP y33D9MGG5E+CvNDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90E613EA69; Mon, 2 Mar 2026 13:45:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F89nH2OUpWlLCwAAD6G6ig (envelope-from ); Mon, 02 Mar 2026 13:45:07 +0000 Date: Mon, 2 Mar 2026 14:45:01 +0100 From: Petr Vorel To: Piotr Kubaj Message-ID: <20260302134501.GA280343@pevik> References: <20260226143134.138506-3-piotr.kubaj@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260226143134.138506-3-piotr.kubaj@intel.com> X-Spamd-Result: default: False [-3.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[7]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:replyto,suse.cz:email]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v10] thermal: add new test group X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: helena.anna.dubel@intel.com, tomasz.ossowski@intel.com, rafael.j.wysocki@intel.com, ltp@lists.linux.it, daniel.niestepski@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Piotr, all, I like the runtime drastically speedup :). ... > +static void cleanup(void) > +{ > + if (x86_pkg_temp_tz_found) > + SAFE_FILE_PRINTF(trip_path, "%d", trip); We discussed EINVAL error on a first run in [1] thermal_interrupt_events.c:178: TWARN: Failed to close FILE '/sys/class/thermal/thermal_zone1/trip_point_1_temp': EINVAL (22) This happens in safe_file_vprintf(), just TBROK is converted to TWARN due being in cleanup(). I wonder if separate test for this would be useful. You pointed a kernel fix [2] bug git hash changed (now cgit shows Bad commit "reference: 39b1bd1613b8f73994f654988ad75a72b633f5e2"). Do you know the new hash of the fix? Maybe putting the hash info in the test would be useful .tags = (const struct tst_tag[]) { {"linux-git", "..."}, // hash of the fix {} nit (we discussed it in the past): when x86_pkg_temp_tz_found is bool, instead of using 1: x86_pkg_temp_tz_found = 1; would be cleaner to use true. Otherwise LGTM now. Reviewed-by: Petr Vorel Kind regards, Petr [1] https://lore.kernel.org/ltp/20260121230639.GA10001@pevik/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/patch/?id=39b1bd1613b8f73994f654988ad75a72b633f5e2 -- Mailing list info: https://lists.linux.it/listinfo/ltp