Re: [LTP] [PATCH] fanotify25: fix test failure on kernel with CONFIG_MODULES=n

Petr Vorel
2026-03-03T08:53:14Z

> On Mon, Mar 2, 2026 at 4:39 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> > Hi!
> > > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > > ---
> > > testcases/kernel/syscalls/fanotify/fanotify25.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)

> > > diff --git a/testcases/kernel/syscalls/fanotify/fanotify25.c b/testcases/kernel/syscalls/fanotify/fanotify25.c
> > > index c982f3225..9b03fd9ab 100644
> > > --- a/testcases/kernel/syscalls/fanotify/fanotify25.c
> > > +++ b/testcases/kernel/syscalls/fanotify/fanotify25.c
> > > @@ -24,10 +24,10 @@ static const struct traceconfig {
> > > const char *filename;
> > > const char *wdata;
> > > } trace_cmds[] = {
> > > - {EVENTS_SYSFILE, "p:ltp_load_module_0 load_module"},
> > > - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "1"},
> > > - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "0"},
> > > - {EVENTS_SYSFILE, "-:ltp_load_module_0"},
> > > + {EVENTS_SYSFILE, "p:ltp_load_script_0 load_script"},
> > > + {MNTPOINT "/events/kprobes/ltp_load_script_0/enable", "1"},
> > > + {MNTPOINT "/events/kprobes/ltp_load_script_0/enable", "0"},
> > > + {EVENTS_SYSFILE, "-:ltp_load_script_0"},

> > Doesn't this depend on CONFIG_BINFMT_SCRIPT? How likely is that this is
> > turned off?

> CONFIG_MODULES=n is a common config for testing
> I don't think this is the case for CONFIG_BINFMT_SCRIPT

Yes, it's default y and just briefly checking it's in Tumbleweed and Debian
testing => LGTM.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> > If possible I would like to avoid whack-a-mole game trying to find
> > something that is commonly enabled.

> Feel free to choose any other symbol.

> Thanks,
> Amir.