Re: [LTP] [PATCH] fanotify25: fix test failure on kernel with CONFIG_MODULES=n

Amir Goldstein
2026-03-03T10:10:52Z

On Tue, Mar 3, 2026 at 10:59 AM Martin Doucha <mdoucha@suse.cz> wrote:
>
> On 3/3/26 10:54, Amir Goldstein wrote:
> > On Tue, Mar 3, 2026 at 10:49 AM Martin Doucha <mdoucha@suse.cz> wrote:
> >>
> >> Hi,
> >> how about oom_kill_process()? That one's unconditionally available and
> >> shouldn't get called very often in a reasonable test environment either.
> >
> > Why does it matter how much the function gets called?
> > Isn't that irrelevant for the test?
>
> I've written the test to test a specific fanotify regression. Tracing a
> syscall that gets called too often could increase system load and change
> timing of the race which I'm trying to trigger with it.
>

Which fanotify regression?
As a reviewer, I got no indication in the commit message,
Test description, nor in LTP tst_test tags that this is a test for a regression.

I have no objection whatsoever to using any other symbol available
in most of the common builds.
Alternatively, the test could test for the desired configuration.

But if the test is meant to track a regression, then *please* document
the regression in the test description and the fix commit if such fix
exists in LTP tst_test tags.

Thanks,
Amir.