* [LTP] [PATCH] fanotify25: Trace oom_kill_process() instead of load_module()
@ 2026-03-03 10:55 Martin Doucha
2026-03-06 12:13 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Martin Doucha @ 2026-03-03 10:55 UTC (permalink / raw)
To: ltp; +Cc: Amir Goldstein
The load_module() function is available only if the kernel was built
with CONFIG_MODULES enabled. Trace a function that's unconditionally
available instead.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
Reported-by: Amir Goldstein <amir73il@gmail.com>
---
testcases/kernel/syscalls/fanotify/fanotify25.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify25.c b/testcases/kernel/syscalls/fanotify/fanotify25.c
index c982f3225..db52e6a87 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify25.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify25.c
@@ -24,10 +24,10 @@ static const struct traceconfig {
const char *filename;
const char *wdata;
} trace_cmds[] = {
- {EVENTS_SYSFILE, "p:ltp_load_module_0 load_module"},
- {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "1"},
- {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "0"},
- {EVENTS_SYSFILE, "-:ltp_load_module_0"},
+ {EVENTS_SYSFILE, "p:ltp_oom_kill_process_0 oom_kill_process"},
+ {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "1"},
+ {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "0"},
+ {EVENTS_SYSFILE, "-:ltp_oom_kill_process_0"},
{}
};
--
2.52.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] fanotify25: Trace oom_kill_process() instead of load_module()
2026-03-03 10:55 [LTP] [PATCH] fanotify25: Trace oom_kill_process() instead of load_module() Martin Doucha
@ 2026-03-06 12:13 ` Petr Vorel
2026-03-06 15:47 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2026-03-06 12:13 UTC (permalink / raw)
To: Martin Doucha; +Cc: Amir Goldstein, Jan Kara, ltp
Hi all,
> The load_module() function is available only if the kernel was built
> with CONFIG_MODULES enabled. Trace a function that's unconditionally
> available instead.
+1, that's obviously better than require CONFIG_BINFMT_SCRIPT or anything else.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
@Amir @Jan will you add your ack, please?
Kind regards,
Petr
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> Reported-by: Amir Goldstein <amir73il@gmail.com>
> ---
> testcases/kernel/syscalls/fanotify/fanotify25.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify25.c b/testcases/kernel/syscalls/fanotify/fanotify25.c
> index c982f3225..db52e6a87 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify25.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify25.c
> @@ -24,10 +24,10 @@ static const struct traceconfig {
> const char *filename;
> const char *wdata;
> } trace_cmds[] = {
> - {EVENTS_SYSFILE, "p:ltp_load_module_0 load_module"},
> - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "1"},
> - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "0"},
> - {EVENTS_SYSFILE, "-:ltp_load_module_0"},
> + {EVENTS_SYSFILE, "p:ltp_oom_kill_process_0 oom_kill_process"},
> + {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "1"},
> + {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "0"},
> + {EVENTS_SYSFILE, "-:ltp_oom_kill_process_0"},
> {}
> };
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] fanotify25: Trace oom_kill_process() instead of load_module()
2026-03-06 12:13 ` Petr Vorel
@ 2026-03-06 15:47 ` Jan Kara
2026-03-09 12:56 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kara @ 2026-03-06 15:47 UTC (permalink / raw)
To: Petr Vorel; +Cc: Amir Goldstein, Jan Kara, ltp
On Fri 06-03-26 13:13:36, Petr Vorel wrote:
> Hi all,
>
> > The load_module() function is available only if the kernel was built
> > with CONFIG_MODULES enabled. Trace a function that's unconditionally
> > available instead.
>
> +1, that's obviously better than require CONFIG_BINFMT_SCRIPT or anything else.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> @Amir @Jan will you add your ack, please?
Sure, whatever works for you in this case :)
Acked-by: Jan Kara <jack@suse.cz>
Honza
>
> Kind regards,
> Petr
>
> > Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> > Reported-by: Amir Goldstein <amir73il@gmail.com>
> > ---
> > testcases/kernel/syscalls/fanotify/fanotify25.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> > diff --git a/testcases/kernel/syscalls/fanotify/fanotify25.c b/testcases/kernel/syscalls/fanotify/fanotify25.c
> > index c982f3225..db52e6a87 100644
> > --- a/testcases/kernel/syscalls/fanotify/fanotify25.c
> > +++ b/testcases/kernel/syscalls/fanotify/fanotify25.c
> > @@ -24,10 +24,10 @@ static const struct traceconfig {
> > const char *filename;
> > const char *wdata;
> > } trace_cmds[] = {
> > - {EVENTS_SYSFILE, "p:ltp_load_module_0 load_module"},
> > - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "1"},
> > - {MNTPOINT "/events/kprobes/ltp_load_module_0/enable", "0"},
> > - {EVENTS_SYSFILE, "-:ltp_load_module_0"},
> > + {EVENTS_SYSFILE, "p:ltp_oom_kill_process_0 oom_kill_process"},
> > + {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "1"},
> > + {MNTPOINT "/events/kprobes/ltp_oom_kill_process_0/enable", "0"},
> > + {EVENTS_SYSFILE, "-:ltp_oom_kill_process_0"},
> > {}
> > };
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-09 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 10:55 [LTP] [PATCH] fanotify25: Trace oom_kill_process() instead of load_module() Martin Doucha
2026-03-06 12:13 ` Petr Vorel
2026-03-06 15:47 ` Jan Kara
2026-03-09 12:56 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox